jquery check if input text empty is not working

Question

I have this jquery code

if (($("#RdbDateRange").is(':checked'))
        && (!$("#CldrFrom").val())
        && (!$("#CldrTo").val())) {}else{}

RdbDateRange is ID for radio button. CldrFrom is ID for input text CldrTo is ID for input text.

I want to do something when the radio is selected and both of the inputs not empty.

but that code go inside the if even when the inputs empty.

why please?

Empty strings are definitely false in a boolean context. Try applying $.trim() to filter out whitespace. Note that you do not have to explicitly test against the empty string or use length, as all the answers you received so far would like you to believe. — Frédéric Hamidi
– Frédéric Hamidi, Commented Apr 15, 2014 at 12:28

Satpal · Accepted Answer · 2014-04-15 12:38:25Z

2

Use .length property, For spaces You can use $.trim()

if ($("#RdbDateRange").is(':checked')
    && $.trim($("#CldrFrom").val()).length
    && $.trim($("#CldrTo").val()).length){}else{}

OR,

You can also use .trim(), Note: this function is supported in IE9+

if ($("#RdbDateRange").is(':checked')
    && $("#CldrFrom").val().trim().length
    && $("#CldrTo").val().trim().length){}else{}

EDIT

As per requirement the radio is selected and both of the inputs not empty

You don't need !, thus remove it

edited Apr 15, 2014 at 12:38

answered Apr 15, 2014 at 12:26

Satpal

134k13 gold badges168 silver badges171 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Marco Dinatsoli Over a year ago

maybe the input has spaces, just spaces. ?

Marco Dinatsoli Over a year ago

maybe is there a trim function ?

Marco Dinatsoli Over a year ago

can u use the trim please?

Marco Dinatsoli Over a year ago

it still goes into the if

Satpal Over a year ago

@MarcoDinatsoli, I have updated answer you dont need !

Ajinkya · Accepted Answer · 2014-04-15 12:26:07Z

0

.val() doesnt return true/false. You should check for .val()length == 0 instead of !val()

if (($("#RdbDateRange").is(':checked'))
        && (!$.trim($("#CldrFrom").val()).length == 0)
        && (!$.trim($("#CldrTo").val()).lenght == 0)) {}else{}

answered Apr 15, 2014 at 12:26

Ajinkya

22.7k33 gold badges113 silver badges164 bronze badges

2 Comments

Marco Dinatsoli Over a year ago

so what should I do please?

Marco Dinatsoli Over a year ago

maybe it is just spaces. I mean whites spaces without actually data

PSR · Accepted Answer · 2014-04-15 12:26:50Z

0

Replace !$("#CldrFrom").val() with if($("#CldrFrom").val().trim() !="")

answered Apr 15, 2014 at 12:26

PSR

40.4k43 gold badges115 silver badges154 bronze badges

1 Comment

Marco Dinatsoli Over a year ago

it still goes into the if

user3383479 · Accepted Answer · 2014-04-15 12:27:17Z

0

You must compare in the if clause

 if (($("#RdbDateRange").is(':checked'))
    && (!$("#CldrFrom").val()=="something")
    && (!$("#CldrTo").val()!="")) {}else{}

answered Apr 15, 2014 at 12:27

user3383479

Comments

Milind Anantwar · Accepted Answer · 2014-04-15 12:27:23Z

0

Try this:

&& (!$("#CldrTo").val().length)) {
//Text is not empty....code here...
}

answered Apr 15, 2014 at 12:27

Milind Anantwar

82.3k26 gold badges97 silver badges128 bronze badges

Comments

Dhambha · Accepted Answer · 2014-04-15 12:37:04Z

0

Try this

if (($("#RdbDateRange").is(':checked'))
        && ($("#CldrFrom").val() !='')
        && ($("#CldrTo").val() !='')) {}else{}

DEMO

edited Apr 15, 2014 at 12:37

Dhambha

821 silver badge8 bronze badges

answered Apr 15, 2014 at 12:28

Sridhar R

20.4k7 gold badges41 silver badges35 bronze badges

Collectives™ on Stack Overflow

jquery check if input text empty is not working

6 Answers 6

EDIT

5 Comments

2 Comments

1 Comment

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

EDIT

5 Comments

2 Comments

1 Comment

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related