Android SQLite database exception

Question

Currently having an issue in my SQLite database in android, when I try and run a comparison I get the following error: Caused by: android.database.sqlite.SQLiteException: near "@hotmail": syntax error: , while compiling: SELECT DISTINCT _id, userName, password FROM userTable WHERE [email protected] password=shshsh

my search is:

public boolean getUserNameAndPassword(String userName, String Password) throws SQLException {

    Cursor mCursor =
            db.query(true, TABLE_NAME, new String[] {KEY_ROWID,USER,
                    PWD},USER + "=" + userName + "AND password=" + Password, null,
                    null, null, null, null);

    if (mCursor.getCount() > 0)
    {
        return true;
    }
    return false;}

My attempt to run it is:

  boolean signIn = dbHelper.getUserNameAndPassword(mEmail, mPassword);
        if (signIn){
            Toast.makeText(getBaseContext(),"Sign in successful",Toast.LENGTH_LONG).show();
        }else {Toast.makeText(getBaseContext(),"Sign in failed",Toast.LENGTH_LONG).show();}

Thanks in advance!

this is exactly why you should use selectionArgs and ?.

njzk2
– njzk2

2014-04-16 18:12:24 +00:00
Commented Apr 16, 2014 at 18:12 — njzk2
– njzk2, Commented Apr 16, 2014 at 18:12

John Boker · Accepted Answer · 2014-04-16 19:26:47Z

2

You should used a parameterized queries instead of just appending in the username and password variables, see the example below:

Cursor mCursor =
        db.query(true, TABLE_NAME, new String[] {KEY_ROWID,USER,
                PWD},USER + " = ? AND password = ?", new String[]{ userName, Password },
                null, null, null, null);

if (mCursor.getCount() > 0)
{
    return true;
}
return false;}

edited Apr 16, 2014 at 19:26

answered Apr 16, 2014 at 18:11

John Boker

83.8k17 gold badges101 silver badges130 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

nhaarman Over a year ago

You should also remove the password appending from the query :)

user3535757 Over a year ago

Hi John, thanks for the prompt response, I have changed to what you have said but I am still getting: Caused by: android.database.sqlite.SQLiteException: near "example": syntax error: , while compiling: SELECT DISTINCT _id, userName, password FROM userTable WHERE userName = ? AND password = ?example

John Boker Over a year ago

i dont see where the word 'example' is getting into the query.

user3535757 Over a year ago

It is part of the two text entry fields and once they are entered clicking the sign in button fires them in. mEmail = mEmailView.getText().toString(); mPassword = mPasswordView.getText().toString();

John Boker Over a year ago

@NiekHaarman good catch, copy and paste malfunction i think :) Try now.

nhaarman · Accepted Answer · 2014-04-16 18:11:11Z

1

SELECT DISTINCT _id, userName, password FROM userTable WHERE [email protected] password=shshsh

You forgot a space between userName and AND.

Furthermore, have a look at John's answer about parameterized queries.

answered Apr 16, 2014 at 18:11

nhaarman

101k55 gold badges254 silver badges283 bronze badges

Comments

MohdTausif · Accepted Answer · 2014-04-16 18:14:14Z

0

try this:

Cursor mCursor =
            db.query(true, TABLE_NAME, new String[] {KEY_ROWID,USER,
                    PWD},USER+"='"+userName+"' AND password='"+Password+"'", null,
                    null, null, null, null);

answered Apr 16, 2014 at 18:14

MohdTausif

5084 silver badges14 bronze badges

Comments

Rafag · Accepted Answer · 2014-04-16 19:14:23Z

0

You forgot a space, try now:

Cursor mCursor =
            db.query(true, TABLE_NAME, new String[] {KEY_ROWID,USER,
                    PWD},USER + "='" + userName + "' AND password='" + Password + "'", null,
                    null, null, null, null);

    if (mCursor.getCount() > 0)
    {
        return true;
    }
    return false;}

Edit: Also, you should think about using parameterized queries as John proposes.

edited Apr 16, 2014 at 19:14

answered Apr 16, 2014 at 18:13

Rafag

7293 gold badges11 silver badges27 bronze badges

1 Comment

user3535757 Over a year ago

Hi there, with your solution I get the following error: Caused by: android.database.sqlite.SQLiteException: near "@hdjsj": syntax error: , while compiling: SELECT DISTINCT _id, userName, password FROM userTable WHERE [email protected] AND password=sjsjsj

Collectives™ on Stack Overflow

Android SQLite database exception

4 Answers 4

5 Comments

Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

5 Comments

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related