C program array and for loop exercise

Question

I have to write a function which checks if a value is located in an array with N elements using for loop.I wrote the code

 #include <stdio.h>
int main ()
int N[100],n,i; 
printf ("Write the value of n:");
scanf ("%d",&n);
i=0;

      printf ("Write the value of the element :");
      scanf ("%d",&v[i]);
      for (i=0,i<n,i++)
      {
          if (N[i]==n)
          }
          printf ("The value is located in the array :");



return 0;

When I compile it,it says syntax error before printf.What does this mean?What have I done wrong?

You need to enclose the printf with brackets { printf();}. You also have to close the bracket for the for loop. And where are the brackets for the main? — AntonH
– AntonH, Commented Apr 16, 2014 at 21:27
Putting brackets around printf isn't going to solve this problem. To start with, your entire main function needs brackets; the syntax is something like int main () { ...code goes here... }. — larsks
– larsks, Commented Apr 16, 2014 at 21:28
"You need to enclose the printf with brackets { printf();}" -- please don't write ignorant nonsense. — Jim Balter
– Jim Balter, Commented Apr 16, 2014 at 21:34

Ed Swangren · Accepted Answer · 2014-04-16 21:34:37Z

2

Basic syntax issues. Try:

#include <stdio.h>

int main(void)
{
    int N[100],n,i; 
    printf ("Write the value of n:");
    scanf ("%d",&n);
    i=0;
    printf("Write the value of the element :");
    scanf("%d", &v[i]);  /* v doesn't exist */

    /* you are looping up to n, which could be anything */
    for (i=0; i<n; i++)
    {
        /* you never populate N, so why would you expect n to be found?
        the value of any element in N is indeterminate at this point */
        if (N[i]==n)
        {
            printf ("The value is located in the array :");
        }
    }      

    return 0;
}

That said, you have logical problems here:

v is not declared anywhere.
You never populate your array (N).
n is a value entered by the user, not the upper bound of the array. What if I enter 101?

Those are more than syntax issues, you'll need to fix your logic.

edited Apr 16, 2014 at 21:34

answered Apr 16, 2014 at 21:29

Ed Swangren

125k24 gold badges189 silver badges271 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

C program array and for loop exercise

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related