JavaScript Required Validation on Input not working

Question

I have 2 simple JS function one checks values of 2 input fields and triggers the other function Here is the code

function ValidateForm()
    {
    var name = document.getElementById('fullname').value;
     var email = document.getElementById('email').value;
     if(name.value= '' || email.value='')
     {
     alert('fields Empty');
     }
     else
     {
     UpdateRecord();
     }

    }


    function UpdateRecord()
    {
    var Qact = getQueryVariable('ACT');
        if(Qact==2){

            var picture= document.getElementById('myPic').src;
            activity.setUpdates(name,email,picture);
            }
            else
            {
            activity.CheckEmail(name,email);
            }
        }

HTML

<button onClick="ValidateForm();" data-role="button" >Register</button>

if I call UpdateRecord() on button click it works fine but when i use ValidateForm() nothing works. The firefox debugger don't even go to the ValidateForm() Function

you are asigning value , not matching valuename.value= '' use==. — Himanshu
– Himanshu, Commented Apr 17, 2014 at 6:09

SeanCannon · Accepted Answer · 2014-04-17 06:16:19Z

6

if(name.value= '' || email.value='')

should be

if(name === '' || email === '')

edited Apr 17, 2014 at 6:16

answered Apr 17, 2014 at 6:08

SeanCannon

78.1k17 gold badges126 silver badges145 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

AddyProg Over a year ago

thanks it worked but now its calling UpdateRecord() even when input fields are empty . . .

SeanCannon Over a year ago

See my update. You were trying to reference element.value.value

AddyProg Over a year ago

It didn't worked for me , but this did if(name.value == null || email.value == null) but you pointed out the basic mistake thanks :-)

SeanCannon Over a year ago

No, name.value would be null because you were doing document.getElementById('foo').value <-- notice the .value. Then you were looking at the .value again. So of course name.value.value would be undefined, or falsy null.

Sergio · Accepted Answer · 2014-04-17 06:27:30Z

0

if(name.value== '' || email.value=='')
{
    alert('fields Empty');
}
else
{
    UpdateRecord();
}

edited Apr 17, 2014 at 6:27

Sergio

6,9485 gold badges33 silver badges55 bronze badges

answered Apr 17, 2014 at 6:10

D Mishra

1,6081 gold badge14 silver badges17 bronze badges

Comments

Martin Prikryl · Accepted Answer · 2014-04-17 06:32:32Z

0

Try this to compare values:

if(name.value == '' || email.value == '')
{
    alert('fields Empty');
}
else
{
    UpdateRecord();
}

edited Apr 17, 2014 at 6:32

Martin Prikryl

205k64 gold badges560 silver badges1.1k bronze badges

answered Apr 17, 2014 at 6:10

user3497034

Collectives™ on Stack Overflow

JavaScript Required Validation on Input not working

3 Answers 3

4 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

4 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related