How to use php variable inside a javascript code in a php code?

Question

How can I implement this:

<?php
    echo "<script type='text/javascript'>";
    echo "document.getElementById('table_apps').innerHTML = json_encode($td_temp);";
    echo "</script>";
?>

There is a problem with $td_temp;

Have you set $td_temp with some text or something? You can use isset to check — Justin Mitchell
– Justin Mitchell, Commented Apr 19, 2014 at 6:01
Yes there is a string inside of the $td_temp to draw a table. I checked it. That's OK. — Sponge Bob
– Sponge Bob, Commented Apr 19, 2014 at 6:03
It's also because json_encode is a php function, so you need to remove it from the string eg. " . json_encode — Justin Mitchell
– Justin Mitchell, Commented Apr 19, 2014 at 6:05
I've added an answer that I think you'll find useful from an informational/learning perspective — Justin Mitchell
– Justin Mitchell, Commented Apr 19, 2014 at 10:09

Nambi · Accepted Answer · 2014-04-19 06:13:46Z

2

json_encode() is a PHP function

Do like this

echo "document.getElementById('table_apps').innerHTML ='".json_encode($td_temp)."';";

edited Apr 19, 2014 at 6:13

answered Apr 19, 2014 at 6:01

Nambi

12k4 gold badges40 silver badges50 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Justin Mitchell Over a year ago

innerHTML should be wrapped in single quotes as well as escaping any single quotes in the json data.

Sponge Bob Over a year ago

That's exactly what I want. Thanks.

Alex Over a year ago

'".json_encode($td_temp)."' - it's wrong no need for single qoutes

Alex Over a year ago

@SpongeBob author you should better use my example, believe me i know what i'm talking about

Justin Mitchell Over a year ago

@Alex, I don't agree, if anything your answer was originally wrong and is still incomplete. You don't encapsulate the encoded json string in quotes, nor escape it. This was accepted as correct because it did at least encapsulate the string which is at least 50% correct. The next best answer was provided by Satish because he provided two clear examples of generating PHP with HTML.

Satish Sharma · Accepted Answer · 2014-04-19 06:03:17Z

2

you can try this without echo

<?php

// some code

?>
       <script type='text/javascript'>
          document.getElementById('table_apps').innerHTML = '<?php echo json_encode($td_temp);?>';
       </script>

<?php

// some code

?>

UPDATE 2 :

<?php
    echo "<script type='text/javascript'>";
    echo "document.getElementById('table_apps').innerHTML = '".json_encode($td_temp)."';";
    echo "</script>";
?>

answered Apr 19, 2014 at 6:03

Satish Sharma

9,6356 gold badges31 silver badges52 bronze badges

1 Comment

Justin Mitchell Over a year ago

Escape the json for single quotes and this answer is correct

Alex · Accepted Answer · 2014-04-19 06:14:51Z

1

You should better print not all this html from php, but only a variable. Looks more neat

?>
<script type='text/javascript'>
document.getElementById('table_apps').innerHTML = <?php echo json_encode($td_temp); ?>;
</script>
<?php

edited Apr 19, 2014 at 6:14

answered Apr 19, 2014 at 6:01

Alex

8,0827 gold badges44 silver badges61 bronze badges

7 Comments

Justin Mitchell Over a year ago

Your syntax is wrong and you have <?php echo encapsulated in a string

Alex Over a year ago

@Justin Mitchell you sure? check it, it's not wrong

Sponge Bob Over a year ago

Thanks but I want it in php.

Justin Mitchell Over a year ago

You updated while I was posting my first comment. Also, you need to escape the json and surround it in single quotes.

Alex Over a year ago

no i don't need, check it, single quotes adds automatically echo json_encode("sfhafdh");

|

Teerath Kumar · Accepted Answer · 2016-10-26 17:59:52Z

0

    <?php
        echo "<script type='text/javascript'>";
        echo "document.getElementById('table_apps').innerHTML = '".json_encode($td_temp)."';";
        echo "</script>";
    ?>
Try this.

edited Oct 26, 2016 at 17:59

answered Apr 19, 2014 at 6:02

Teerath Kumar

4985 silver badges15 bronze badges

4 Comments

Sponge Bob Over a year ago

Thanks but It doesn't work. Error: Uncaught SyntaxError: Unexpected token <

Justin Mitchell Over a year ago

That's because the string wasn't quoted or escaped

Justin Mitchell Over a year ago

And because json_encode is still encapsulated inside or a php string and will be interpreted literally

Teerath Kumar Over a year ago

but down voting really discourage a developer's strength. :(

Justin Mitchell · Accepted Answer · 2014-04-19 10:08:35Z

-1

It's vitally important to:

encapsulate the encoded json string in quotes
escape any encoded json string

Why?

Because if you were to provide an array of names for example, and you had O'Connell or any other name that has a quotation mark in it, then the innerHTML = '<?php echo json_encode...' would break because of an un-escaped quotation mark. It's important to practise proper encapsulation and validation as much as possible because it future proofs any application you develop, reduces points of failure, or in the case of try/catch/exception, clearly defines intended points of failure.

What happens if you were to create a json object that had a semi-colon in the content? Unless you're wrapping your json content in single quotes and correctly escaping it, it might be interpreted literally as the termination of the current command. So when you try to enter .innerHTML='{blah:"something O'Connel;...}', your Javascript will throw an error because of bad formatting, not to mention it can't interpret 'Connel' before the terminating character. Some browsers are more slack that others (IE I'm looking at you) and will either skip validation or perform a sub-standard routine, or in the case of IE6-8, perform the wrong validation.

There have been mostly correct and incorrect answers so far, but so far all answers have neglected to do one thing, escape quotes:

<?php
    echo "<script type='text/javascript'>";
    echo "document.getElementById('table_apps').innerHTML = '" . addslashes(json_encode($td_temp)) . "';";
    echo "</script>";
?>

That will correctly:

Escape quotes, and
Generate a json-encoded object

answered Apr 19, 2014 at 10:08

Justin Mitchell

3041 silver badge5 bronze badges

2 Comments

Alex Over a year ago

s"o/me_s\tr var a = "s\"o\/me\_s\\tr"; var b = '\"s\\\"o\\/me\\\_s\\\\tr\"'; the second is your string. check it in firebug console it's not working

Justin Mitchell Over a year ago

PHP Console: php > $a = array("apples" => "o'connel"); php > print json_encode($a); {"apples":"o'connel"} Notice how it doesn't add slashes? You can also be selective about the addslashes function, I suggest you read up on it. How do I know? Well, it's because I've developed a number of REST applications and ajax driven web applications using JSON as the message content service.

Collectives™ on Stack Overflow

How to use php variable inside a javascript code in a php code?

5 Answers 5

5 Comments

1 Comment

7 Comments

4 Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

5 Comments

1 Comment

7 Comments

4 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related