php foreach loop insert into two tables

Question

I want to insert the array into table.

Each name can have multiple addresses.

Name will be in table1 and all the addresses will be in another table2 corresponding to the name

my array is below:

array
(
[name] => Array
        (
            [0] => jack
            [1] => jill
            [2] =>  tom

        )
[address] => Array
        (
           [0] => array
            (

            [0] => jack_aadress1
            [1] => jack_aadress2
            [2] =>  jack_aadress3

        )   
         [1] => array(


            [0] => jill_address1
            [1] => jill_address2
            [2] => jill_address3

        ) 

         [2] => array(


            [0] => tom_address1
            [1] => tom_address2
            [2] => tom_address3

        )       


)

Below is the one I tried:

foreach($_REQUEST['room_name'] as $key=>$value)
{
  mysql_query("insert into table1(name) values($value)");
  $insert_id = mysql_insert_id();
   foreach($_REQUEST['address'] as $key1=>$value1)
   {
       mysql_query("insert into table2(id,address) values($insert_id,$value1)");

   }
}

Mysql is deprecated please switch to mysqli or pdo.

the_pete
– the_pete

2014-04-21 18:51:37 +00:00
Commented Apr 21, 2014 at 18:51 — the_pete
– the_pete, Commented Apr 21, 2014 at 18:51

Barmar · Accepted Answer · 2014-04-21 19:00:24Z

1

You're not drilling deep enough into the second array. It should be:

foreach($_REQUEST['name'] as $key=>$value)
{
    $value = mysql_real_escape_string($value);
    mysql_query("insert into table1(name) values('$value')");
    foreach($_REQUEST['address'][$key] as $key1=>$value1)
    {
        $value1 = mysql_real_escape_string($value1);
        mysql_query("insert into table2(id,address) values(LAST_INSERT_ID(),'$value1')");

    }
}

edited Apr 21, 2014 at 19:00

answered Apr 21, 2014 at 18:53

Barmar

789k57 gold badges554 silver badges669 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Barmar Over a year ago

I've added escaping and proper quoting to the queries. But it would be better if you converted to mysqli or PDO so you could use parametrized queries instead of variable substitution.

Pank · Accepted Answer · 2014-04-21 19:07:14Z

0

foreach($_REQUEST['name'] as $key=>$value)
{
  mysql_query("insert into table1(name) values('$value')");
  $insert_id = mysql_insert_id();
   foreach($_REQUEST['address'][$key] as $key1=>$value1)
   {
       mysql_query("insert into table2(id,address) values($insert_id, '$value1')");

   }
}

answered Apr 21, 2014 at 19:07

Pank

14.4k10 gold badges35 silver badges46 bronze badges

Collectives™ on Stack Overflow

php foreach loop insert into two tables

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related