Removing an element from an array

Question

I need to remove an element from my profile[] array, then move back all other elements in the array to fill in the now empty space. This is my attempt at doing the first part of the problem, gives a -fpermissive error, Advice?

void deleteCreature(int numCreatures, Creatures profile[])

{

for (int x = 0; x < numCreatures; x++)
{
    cout << "The following is a list of all the creatures you take care of:"
        << profile[x].name << endl << endl << endl;

    cout << "What creature do you wish to remove?" << endl
        << "CREATURE NAME: ";
    cin.ignore();
    getline(cin, profile[numCreatures].name);

    std::vector<int> array;

    auto it = std::find(array.begin(), array.end(), profile[numCreatures].name);
    if (it != array.end())
    {
        array.erase(it);
    }
    else 
    {
        std::cerr << "Could not find profile!\n";
    }

    cout << "You have removed " << profile[x].name << "." << endl << endl;*/
}

}

EDITED

Use a container insted, like std::vector or std::list. Don't re-invent the wheel. — Jepessen
– Jepessen, Commented Apr 23, 2014 at 15:18
@Jepessen while that is good advice in general, this kind of problem is often set as an exercise to students where this is not possible. — mathematician1975
– mathematician1975, Commented Apr 23, 2014 at 15:19
This is not valid C++ code. However, are you sure you don't mean profile[x] instead of profile[num] in your loop? — Marius Bancila
– Marius Bancila, Commented Apr 23, 2014 at 15:20
delete is a C++ keyword. You can't use it as the name function or variable. Choose a different name. — David G
– David G, Commented Apr 23, 2014 at 15:25

Baum mit Augen · Accepted Answer · 2014-04-23 15:47:19Z

2

Why do people insist on rewriting existing code...

The standard-library does all the work for you:

Version 1: (only use if you have to use C-Style arrays)

std::remove(array,array+arraySize,profile[num].name);

Then set the last element to zero and adjust arraySize, done.

Version 2: (the C++ way to do this)

Save the contents of array in an std::vector. You can initialize it from a range, with initializer lists or push_back().

std::vector</*whatever type array stores*/> array;
//Initialize array
array.erase(std::find(array.begin(),array.end(),profile[num].name));

The vectorkeeps track of its size and allocated memory automatically, so you canot get it wrong.

If you are not sure the profile exists, test result_of_find != array.end() before you erase, in the first version check result_of_remove == arraySize - 2.

For example in version 2:

std::vector<int> array;
//Initialize array
auto it = std::find(array.begin(),array.end(),profile[num].name);
if (it != array.end()){
    array.erase(it);
}
else {
    std::cerr << "Could not find profile!\n";
    //Handle error
}

edited Apr 23, 2014 at 15:47

answered Apr 23, 2014 at 15:33

Baum mit Augen♦

50.4k25 gold badges153 silver badges187 bronze badges

Sign up to request clarification or add additional context in comments.

8 Comments

Baalzamon Over a year ago

std::vector<int> array; 		result_of_find != array.end(); 		array.erase(std::find(array.begin(), array.end(), profile[numCreatures.name]));

Like this?

Baalzamon Over a year ago

std::vector<int> array; Does this initialize the array?

Baalzamon Over a year ago

compiler says 'vector' is not a memeber of 'std' derp derp fixed it didnt add the header

Baum mit Augen Over a year ago

In a sense yes, but the default constructed vector is empty. You can fill it for example like std::vector<int> array = {1,2,3,4};. arraynow contains the elements 1,2,3 and 4 in that order. You need to #include <vector> to use it. For more information on vectorsee en.cppreference.com/w/cpp/container/vector

Baalzamon Over a year ago

Could i populate that array with another array earlier in the program, such as where profile[numCret].name is stored?

|

Collectives™ on Stack Overflow

Removing an element from an array

1 Answer 1

8 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

8 Comments

Your Answer

Sign up or log in

Post as a guest

Related