How to combine similar functions - Javascript

Question

I have two functions that are very similar and I would like if possible to combine them. The only issue that I have is one function is accepting 2 arguments and the other one is accepting 3. Is there a way to do this or these two functions have to stay separated by design?

function getClientData(id, command) {

    var formData = {
        'method': command,
        'id': id
    };

    getEntityData(formData);
}


function getLocation(id, clientid, command) {

    var formData = {
        'method': command,
        'locationid': id,
        'clientbrandid': clientid
    };

    getEntityData(formData);
}

Update

function getEntityData(data) {

    var url = '/../admin/miscellaneous/components/global.cfc?wsdl';

    var ajaxResponse = $.ajax({
        url: url,
        dataType: 'json',
        data: data,
        global: false,
        async:false,
        cache: false,
        success: function(apiResponse){
            return apiResponse;
        }
    }).responseJSON;

    var response = ajaxResponse[0];

    for (var i in response) {
        if (response.hasOwnProperty(i)){
            $("#edit"+i).val(response[i].trim());
        }
    }
}

Really you have 4 parameters as id and locationid are passed to getEntityData with different names. Are they the same thing? You haven't shown what getEntityData does. — RobG
– RobG, Commented Apr 24, 2014 at 22:26
I will update now. The getEntityData is just an ajax function which takes the data in the data: section. — Geo
– Geo, Commented Apr 24, 2014 at 22:31

bto.rdz · Accepted Answer · 2014-04-24 22:25:56Z

4

yes you can, I prefer instead of passing each parameter you can pass a js object, and decide wich params it contains for example:

function getLocation(options) {

    getEntityData(options);
}

and your call should be:

getLocation({'method': command,'id': id})

Update

or you can just avoid getLocation function and just call getEntityData

getEntityData({
    'method': command,
    'id': id
});

edited Apr 24, 2014 at 22:25

answered Apr 24, 2014 at 22:19

bto.rdz

6,7404 gold badges41 silver badges56 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Geo Over a year ago

this looks awesome. Will try it and let you know!!

Colin DeClue Over a year ago

At this point, having the getLocation function is useless, isn't it? He could just call getEntityData directly.

Geo Over a year ago

That is what i was thinking as well @ColinDeClue. Thanks for the update :)

Viktor · Accepted Answer · 2014-04-24 22:24:53Z

3

I would go with:

function getWhatever(id, command, clientId) {
    var formData = { method: command };

    if (typeof clientId === 'undefined') {
        formData.id = id;
    } else {
        formData.locationid = id;
        formData.clientbrandid = clientId;
    }

    getEntityData(formData);
}

answered Apr 24, 2014 at 22:24

Viktor

5172 gold badges8 silver badges27 bronze badges

Comments

Jared Farrish · Accepted Answer · 2014-04-24 22:24:56Z

3

function getLocation(id, clientid, command) {
    var formData = {
        'method': command,
        'locationid': id
    };

    if (clientid) {
        formData['clientbrandid'] = clientid;
    }

    getEntityData(formData);
}

// With
getLocation(1, 2, 'doStuff');

// Without
getLocation(1, '', 'doStuff');

Maybe a more rational order of arguments:

function getLocation(id, command, clientid) {
    var formData = {
        'method': command,
        'locationid': id
    };

    if (clientid) {
        formData['clientbrandid'] = clientid;
    }

    getEntityData(formData);
}

// With
getLocation(1, 'doStuff', 2);

// Without
getLocation(1, 'doStuff');

And if locationid and id are different:

function getLocation(id, command, clientid) {
    if (clientid) {
        var formData = {
            'method': command,
            'locationid': id,
            'clientbrandid': clientid
        };
    } else {
        var formData = {
            'method': command,
            'id': id,
        };
    }

    getEntityData(formData);
}

// With
getLocation(1, 'doStuff', 2);

// Without
getLocation(1, 'doStuff');

edited Apr 24, 2014 at 22:24

answered Apr 24, 2014 at 22:17

Jared Farrish

49.4k17 gold badges100 silver badges108 bronze badges

2 Comments

M.Scherzer Over a year ago

just be aware that if you are doing this in an existing codebase that actively uses these to function that the function signature (order of arguments is different). you will need to refactor your existing code.

RobG Over a year ago

Might be better to make the optional argument last so it doesn't need to be elided.

Robert · Accepted Answer · 2014-04-25 14:32:42Z

3

I guess it really depends on what your arguments actually are, but this is also a solution. (Assuming that client id is an object).

function getLocation(id, command, clientid) {

    var _clientId = clientid || {};

    var formData = {
        'method': command,
        'locationid': id,
        'clientbrandid': _clientid
    };

    getEntityData(formData);
}

edited Apr 25, 2014 at 14:32

answered Apr 24, 2014 at 22:19

Robert

316 bronze badges

1 Comment

Joseph Marikle Over a year ago

shouldn't that be 'clientbrandid': _clientid? Otherwise it's just an unused variable, correct?

Collectives™ on Stack Overflow

How to combine similar functions - Javascript

4 Answers 4

3 Comments

Comments

2 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

3 Comments

Comments

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related