while loop and reading from console in java

Question

i am trying to make a big loop for console application in java, it works but after every step, for example after pressing "a" (code, corresponding to "a" letter) works , but every time it writes :"Your input is not correct, please try again", i don't understand why

boolean inputIsValid = false;
            while (!inputIsValid) {
                String input = reader.readLine();
                if (input.equals("a")) {
                    .....

                }
                if (input.equals("p")) {

                   .....

                }


                if (input.equals("q")) {
                    break;
                }
                else {
                    System.out.println("Your input is not correct, please try again");
                }
            }

Blorgbeard · Accepted Answer · 2014-04-27 21:42:54Z

2

Your final else block is only connected to the "q" condition, not to all the others. So it will execute every time that the input is not equal to "q".

You would see this happening if you stepped through the code (a hint for next time :).

You want a real if-else chain, like this:

if (input.equals("a")) {
    .....    
}
else if (input.equals("p")) {    
   .....    
}        
else if (input.equals("q")) {
    break;
}
else {
    System.out.println("Your input is not correct, please try again");
}

answered Apr 27, 2014 at 21:42

Blorgbeard

104k50 gold badges237 silver badges276 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

while loop and reading from console in java

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related