Spaces in additional variable value

Question

I've tried to give my "get_threads" variable some additional content, based on the actual case. But it doesn't work as expected, the query isn't executing at all. It looks like there are some blanks that are missing in the "final" variable. But when i add them to the value, the output completely dissapears.

The output query is:

SELECT id, main_forum_id, icon_id, title, description, author_id, closed, views, posts, date_created, last_post_author_id, last_replyTime FROM forum_thread WHERE main_forum_id= ('1') ORDER BY views ASC LIMIT 0, 20

And that's the code:

$get_threads  = "SELECT id, main_forum_id, icon_id, title, description, author_id, closed, views, posts, date_created, last_post_author_id, last_replyTime FROM forum_thread WHERE main_forum_id= ('" . $actualBoard . "')";
if (isset($_GET[ 'sortField' ])) {
switch ($_GET[ 'sortField' ]) {
    case topic:
        $get_threads  .= " ORDER BY title ASC ";
        break;

    case rating:
        $get_threads  .= " ORDER BY rating ASC ";
        break;

    case replies:
        $get_threads  .= " ORDER BY replies ASC ";
        break;

    case views:
        $get_threads  .= " ORDER BY views ASC ";
        break;

    case lastReply:
        $get_threads  .= " ORDER BY last_replyTime DESC ";
        break;      
        }
    } else {
$lastReplyClass = 'columnLastPost active';
$get_threads  .= " ORDER BY last_replyTime ASC ";
    }
$get_threads  .= " LIMIT $start, $perPage";

SOLUTION:

Okay, i'm such an idiot.. Had a format function for the time and deleted it. That caused the error:

Fatal error: Call to undefined function formatDateString()

Try to put a white space after all your "ORDER BY [...] ASC|DESC " — Debflav
– Debflav, Commented Apr 28, 2014 at 10:02
insert quotes in case parameters. example: case 'topic': (if topic not defined as constant) — Dell
– Dell, Commented Apr 28, 2014 at 10:35

xate · Accepted Answer · 2014-04-28 10:02:45Z

1

SELECT id, main_forum_id, icon_id, title, description, author_id, closed, views, posts, date_created, last_post_author_id, last_replyTime FROM forum_thread WHERE main_forum_id= ('1') ORDER BY last_replyTime ASCLIMIT 20, 20

ASCLIMIT ?

There has to be a space.

You should add a space before your LIMIT and before your ORDER BY

$get_threads  .= " ORDER BY last_replyTime ASC";
    }
$get_threads  .= " LIMIT $start, $perPage";

answered Apr 28, 2014 at 10:02

xate

6,3723 gold badges20 silver badges43 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

RedDragon55 Over a year ago

I know, but that's the problem. If i add a space, the output is: nothing. No PHP error, no MySql error. Just nothing.

xate Over a year ago

Try to use the query in the database and try if it works, thats the first step in debugging SQL =)

xate Over a year ago

the output cant be nothing, only because you add a space. Then you add the space in the wrong place or something oo. A space doesn´t kill anything.

RedDragon55 Over a year ago

Edited code you can see on the top. I am REALLY sure, that my code is correct. Before i splitted the query into this parts, it worked like a charm. And it's just all about that damn spaces.

xate Over a year ago

Your still missing the space before the LIMIT, it still says ASCLIMIT instead of ASC LIMIT

|

Dell · Accepted Answer · 2014-04-28 10:46:12Z

$get_threads  = "SELECT id, main_forum_id, icon_id, title, description, author_id, closed, views, posts, date_created, last_post_author_id, last_replyTime FROM forum_thread WHERE main_forum_id= ('" . $actualBoard . "') ";
    $sortField = (isset($_GET[ 'sortField' ])) ? $_GET[ 'sortField' ] : '';

    switch ($sortField) {
        case 'topic':
            $get_threads  .= " ORDER BY title ASC ";
            break;

        case 'rating':
            $get_threads  .= " ORDER BY rating ASC ";
            break;

        case 'replies':
            $get_threads  .= " ORDER BY replies ASC ";
            break;

        case 'views':
            $get_threads  .= " ORDER BY views ASC ";
            break;

        case 'lastReply':
            $get_threads  .= " ORDER BY last_replyTime DESC ";
            break;      
        default:{
            $lastReplyClass = 'columnLastPost active';
            $get_threads  .= " ORDER BY last_replyTime ASC ";
            }
            break;      
    }

    $get_threads  .= " LIMIT $start, $perPage";

Ranjith · Accepted Answer · 2014-04-28 11:06:55Z

0

Give the space between ORDER BY last_replyTime ASC and LIMIT 20 20

Also switch case surrounded with single(') or double("") quotes.

For example,

case "topic":
 break;
case "views":
 break;

edited Apr 28, 2014 at 11:06

answered Apr 28, 2014 at 10:04

Ranjith

2,8393 gold badges24 silver badges42 bronze badges

6 Comments

RedDragon55 Over a year ago

That's the point of this question...When i add the spaces correctly, the output is exaclty nothing.

Ranjith Over a year ago

@RedDragon55 : Before executing, just echo your query, and run on DB. Check if you got any results? Also update your question with your query.

Ranjith Over a year ago

@RedDragon55 : You got any results when running the query? I want that query alone. For example SELECT ... WHERE main_forum_id= ('1') ... LIMIT 20, 20 not your functional part.

RedDragon55 Over a year ago

Yes, the results i expect. I already posted the query.

SELECT id, main_forum_id, icon_id, title, description, author_id, closed, views, posts, date_created, last_post_author_id, last_replyTime FROM forum_thread WHERE main_forum_id= ('1') ORDER BY views ASC LIMIT 0, 20

Ranjith Over a year ago

@RedDragon55 : You forgot the quotes around the switch case string values. I updated my answer now.

|

Collectives™ on Stack Overflow

Spaces in additional variable value

3 Answers 3

7 Comments

Comments

6 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

7 Comments

Comments

6 Comments

Your Answer

Sign up or log in

Post as a guest

Related