Optimize while and SQL in foreach

Question

My code :

$text = '12-name-y-86';
$array = explode('-',$text);
foreach($array as $value) {
    $sql = mysql_query("SELECT * FROM `table` WHERE `pid`='$value' ORDER BY `id` LIMIT 3");
    echo '***'.$value.'***';
    echo '<br />';    
    while($row = mysql_fetch_array($sql)) {
        echo $row['title'];
        echo '<br />';
    }
    echo '<br /><br />';
}

Print :

12

title1

title2

title3

name

ti1

ti2

ti3

y

tle1

tle2

tle3

86

mytitle1

mytitle2

mytitle3

This code work full buy for more values in $text , server has down !

possible duplicate of How optimize while in while code?

hakre
– hakre

2014-05-11 11:17:01 +00:00
Commented May 11, 2014 at 11:17 — hakre
– hakre, Commented May 11, 2014 at 11:17

vsmoraes · Accepted Answer · 2014-05-07 16:46:16Z

0

Try to select all records in just one query, like this:

$text = '12-name-y-86';
$array = explode('-', $text);
$array = "'" . implode(',', $array) . "'";
$sql = mysql_query("SELECT * FROM `table` WHERE `pid` IN (' . $array . ') ORDER BY `id` LIMIT 3");
while($row = mysql_fetch_array($sql)) {
    echo $row['title'];
    echo '<br />';
}
echo '<br /><br />';

answered May 7, 2014 at 16:46

vsmoraes

1942 silver badges7 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user3612383 Over a year ago

resource(49) of type (mysql result) , but not echo titles !

Collectives™ on Stack Overflow

Optimize while and SQL in foreach

1 Answer 1

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related