retrieving selected value from checkboxlist and using in sql query

Question

I want to create a sql query based on the selected Item from checkboxlist. Just want to remove last comma from the code below.

    String queryt=" And Brand IN(";
        foreach (ListItem lst in brandcklist.Items)
        {
            if (lst.Selected == true)
            {
               queryt += "'"+lst.Text+"',";
            }
        }
        queryt += ")";
        Label3.Text = queryt;

output for this is
And Brand IN('BlackBerry','Karbonn',)
note the comma after karbonn, I don't want to add comma after last item.

You can use string.join. But you should worry about SQL injection — Uriil
– Uriil, Commented May 12, 2014 at 13:24
@Uriil can u explain. Currently i just need to do it for my exam tommorow so its ok i will manage. — ALOK
– ALOK, Commented May 12, 2014 at 13:26

Ashish Charan · Accepted Answer · 2014-05-12 13:32:17Z

1

Just replace this line

queryt += ")";

with

queryt=queryt.TrimEnd(',') +")";

edited May 12, 2014 at 13:32

answered May 12, 2014 at 13:26

Ashish Charan

2,3874 gold badges22 silver badges34 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

ALOK Over a year ago

Its not write. Output now is And Brand IN('BlackBerry','Micromax',

Ashish Charan Over a year ago

I tested it. It works fine. Did u replace the line - > queryt += ")"; ?

ALOK Over a year ago

Yes its working. Actually intellicence selected another var query rather than queryt. Thanks.

Community · Accepted Answer · 2017-05-23 11:57:35Z

0

Something like this:

String queryt = string.Format(" And Brand IN ({0})", string.join(", ", brandcklist.Items.Where(p=>p.Selected).Select(p=>p.Text)))

But as i said, it' open for SQL injection. Here is better description, how you should do this

edited May 23, 2017 at 11:57

CommunityBot

11 silver badge

answered May 12, 2014 at 13:30

Uriil

12.8k11 gold badges54 silver badges73 bronze badges

Collectives™ on Stack Overflow

retrieving selected value from checkboxlist and using in sql query

2 Answers 2

3 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related