How to get all values from JSONObject created with ArrayList ?

Question

I am trying to get values from a json data with AsyncTask. I am getting only the last value and I don't understand why...

I tryed to parse with for each, while but I am doing something wrong :

Here is my code :

private class DecodeData extends AsyncTask<String, Void, String> {

    protected       ArrayList<HashMap<String, String>>    decodedArray;
    protected       HashMap<String, String> decodedMap;
    protected       Iterator<String>        it;
    protected       JSONArray               m_Array;
    protected       JSONObject              object;
    protected       String response;
    protected       String keys;
    protected       String value;

    @SuppressWarnings("unchecked")
    @Override
    protected String doInBackground(String... params) {
        response = params[0];
        keys = "";
        value = "";
        object = null;
        decodedArray = new ArrayList<HashMap<String, String>>();
        try {
            JSONArray arrayResp = new JSONArray(response);
            for (int i = 0; i < arrayResp.length(); i++) {
                decodedMap = new HashMap<String, String>();
                it = arrayResp.getJSONObject(i).keys();
                while (it.hasNext()) {
                    keys = (String)it.next();
                    value = Base64.DecodeStrToStr((String)arrayResp.getJSONObject(i).get(keys));
                    decodedMap.put("\""+keys+"\"", "\""+value+"\"");

                    object = new JSONObject(decodedMap.toString());
                    Log.i("DECODED MAP : ", object.toString());
                    m_Array = new JSONArray();
                    m_Array.put(object);
                    Log.i("M_ARRAY", ""+m_Array);
                }
                //                  decodedArray.add(decodedMap);
            }
        } catch (JSONException e) {
            e.printStackTrace();
        } catch (IOException e) {
            e.printStackTrace();
        }
        //          array = new JSONArray(decodedArray);
        return m_Array.toString();
    }

I am using Volley to get response. After that, I create a JSONArray with this response and I get all keys/values from it. I put all of them in my Hashmap. But when i'm putting keys/values here : m_Array.put(object), it puts only the last value of my json data. Anybody has an idea of what I'm making wrong ?

Could it be because you are creating the map in the for loop, thus creating a new map on each iteration - this is how the old entries get lost. Also another thing to consider: putting a key-value-pair in a map with the same key twice will 'overwrite' the previous pair — Anton Sarov
– Anton Sarov, Commented May 14, 2014 at 15:41
have you tried creating m_Array outside of the loop, too? Right now it is created again on every iteration — Anton Sarov
– Anton Sarov, Commented May 14, 2014 at 15:49

Rukmal Dias · Accepted Answer · 2014-05-14 15:47:17Z

6

Please create JSONArray before starting for loop..

m_Array = new JSONArray();
JSONArray arrayResp = new JSONArray(response);
for (int i = 0; i < arrayResp.length(); i++) { ....

answered May 14, 2014 at 15:47

Rukmal Dias

3,2721 gold badge36 silver badges28 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

takendarkk Over a year ago

It's funny how you (@Fcps) said you tried Anton's solution and it didn't work, and yet this is exactly what he said to do...

Fcps Over a year ago

@Takendarkk He said I created my map in the for loop, it was the JSONArray so it isn't the same to me. Sorry for my no understanding.

Collectives™ on Stack Overflow

How to get all values from JSONObject created with ArrayList ?

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related