Calling a static method from another static method: PHP Fatal error: Call to undefined function

Question

In a simple PHP script (a WordPress module) I have defined a class with several static methods:

class WP_City_Gender {

        public static function valid($str) {
                return (isset($str) && strlen($str) > 0);
        }

        public static function fix($str) {
                return (WP_City_Gender::valid($str) ? $str : '');
        }

        public static function user_register($user_id) {
                if (WP_City_Gender::valid($_POST[FIRST_NAME]))
                        update_user_meta($user_id, FIRST_NAME, $_POST[FIRST_NAME]);
                if (WP_City_Gender::valid($_POST[LAST_NAME]))
                        update_user_meta($user_id, LAST_NAME, $_POST[LAST_NAME]);
                if (WP_City_Gender::valid($_POST[GENDER]))
                        update_user_meta($user_id, GENDER, $_POST[GENDER]);
                if (WP_City_Gender::valid($_POST[CITY]))
                        update_user_meta($user_id, CITY, $_POST[CITY]);
        }
}

Unfortunately I have to prepend the string WP_City_Gender:: to all static method names - even when I call them from static methods.

Otherwise I get the compile error:

PHP Fatal error: Call to undefined function valid()

This seems unusual to me, because in other programming languages it is possible to call static methods from static methods without specifying the class name.

Is there maybe a nicer way here (using PHP 5.3 on CentOS 6), to make my source code more readable?

Use self:: instead of WP_City_Gender::

hindmost
– hindmost

2014-05-15 08:47:37 +00:00
Commented May 15, 2014 at 8:47 — hindmost
– hindmost, Commented May 15, 2014 at 8:47

Bart · Accepted Answer · 2015-09-16 22:47:22Z

5

Indeed, like @hindmost said: Use self:: instead of WP_City_Gender::!

So for instance:

class WP_City_Gender {
....
    public static function valid($str) {
        return (isset($str) && strlen($str) > 0);
    }
    ...
    public static function user_register($user_id) {
        if (self::valid($_POST[FIRST_NAME]))
        ...
    }
}

Hindmost should have made that an answer :). Note that self is WITHOUT the dollar prefix ($), in contrast to $this which DOES have a dollar.

answered Sep 16, 2015 at 22:47

Bart

5,2033 gold badges38 silver badges43 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

rardoz · Accepted Answer · 2014-06-16 17:07:56Z

-2

Use $this->valid() not WP_City_Gender::valid(); If it keeps giving you errors try changing the function from public static function to public function.

answered Jun 16, 2014 at 17:07

rardoz

12210 bronze badges

Collectives™ on Stack Overflow

Calling a static method from another static method: PHP Fatal error: Call to undefined function

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related