converting string to datetime in C# on null value exception

Question

I use the below code

 extensionRequest[i].EndDate = DateTime.Parse(dsResult.Tables[0].Rows[i]["ActualEndDate"].ToString());
 extensionRequest[i].ExtendedEndDate = DateTime.Parse(dsResult.Tables[0].Rows[i]["ExtendedEndDate"].ToString());
 extensionRequest[i].ReceivedDate =Convert.ToDateTime(dsResult.Tables[0].Rows[i]["dReceivedOn"].ToString());

this works fine when values are coming from the DB but when NULL values are returned it throws an exception!!

Should i check values for all three values like the code below

if (dsResult.Tables[0].Rows[i]["dReceivedOn"].ToString()==null){
extensionRequest[i].ReceivedDate="";
}
else{
extensionRequest[i].ReceivedDate =Convert.ToDateTime(dsResult.Tables[0].Rows[i]["dReceivedOn"].ToString());
}

or i should assign all dates to null on exception?!

is there any other way to do in single line? like tryparse or something?

duplicate stackoverflow.com/questions/9953941/…

st4hoo
– st4hoo

2014-05-23 07:26:24 +00:00
Commented May 23, 2014 at 7:26 — st4hoo
– st4hoo, Commented May 23, 2014 at 7:26

Yuval Itzchakov · Accepted Answer · 2014-05-23 07:33:45Z

3

I'll try being creative. You can create a Nullable TryParse as an Extension Method edition:

public static DateTime? TryParseNullable(this DateTime dateTime, string val)
{
    DateTime outValue;
    return DateTime.TryParse(val, out outValue) ? (DateTime?) outValue : null;
}

and then use:

extensionRequest[i].EndDate = DateTime.TryParseNullable(dsResult.Tables[0].Rows[i]["ActualEndDate"].ToString());

and that can be your one liner.

answered May 23, 2014 at 7:33

Yuval Itzchakov

150k32 gold badges275 silver badges333 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Sudhakar Tillapudi · Accepted Answer · 2014-05-23 07:31:40Z

2

You can use DateTime.TryParse() method which returns true on successfull conversion otherwise returns false.

Note: calling ToString() on null throw NullReferenceException hence you need to check for null value before conversion.

Try This:

 if(dsResult.Tables[0].Rows[i]["ActualEndDate"] != null)
    DateTime.TryParse(dsResult.Tables[0].Rows[i]["ActualEndDate"].ToString(),
                                             out extensionRequest[i].EndDate);

edited May 23, 2014 at 7:31

answered May 23, 2014 at 7:25

Sudhakar Tillapudi

26.3k5 gold badges43 silver badges70 bronze badges

1 Comment

Adil Over a year ago

if dsResult.Tables[0].Rows[i]["ActualEndDate"] is null calling ToString will throw execption

mazharenko · Accepted Answer · 2014-05-23 09:23:19Z

1

You can check if value is null like this

extensionRequest[i].EndDate = Convert.IsDbNull(dsResult.Tables[0].Rows[i]["ActualEndDate"]) ? null : Convert.ToDateTime(dsResult.Tables[0].Rows[i]["ActualEndDate"]);

I'm sure .ToString() is not required.

It will be more readable if you cache a row to the local variable:

var row = dsResult.Tables[0].Rows[i];
...
extensionRequest[i].EndDate = Convert.IsDbNull(row["ActualEndDate"]) ? null : Convert.ToDateTime(row["ActualEndDate"]);

Be sure .EndDate and others allow null values. In other words, that is DateTime?

answered May 23, 2014 at 9:23

mazharenko

6557 silver badges11 bronze badges

Collectives™ on Stack Overflow

converting string to datetime in C# on null value exception

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related