Finding Minimum Number Of An Array?

Question

So I am making a program where you write 10 marks and it tells you the maximum and the minimum.

I Have a problem with the Minimum,as the maximum does work.

My problem is that instead of the worst mark,it shows me the first mark entered.

This Is Using Jcreator(Java)

   public void worstEnglish() {
        System.out.println("The Worst English Mark Is");
        //Array
        int worstEnglish = english[0];
        //Method
        for (int i = 0; i < english.length; i++) {
            if (english[i] < worstEnglish) {
                english[i] = worstEnglish;
            }//End Of If
        }//End of loop
    }

Add mode code to make it clear.

vkg
– vkg

2014-05-23 20:24:09 +00:00
Commented May 23, 2014 at 20:24 — vkg
– vkg, Commented May 23, 2014 at 20:24

Leandri · Accepted Answer · 2014-05-23 20:06:37Z

4

you are assigning the value of worstEnglish variable to english array instead of the other way around

if(english[i] < worstEnglish){
    worstEnglish = english[i];
}

answered May 23, 2014 at 20:06

Leandri

1251 silver badge13 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

TGH · Accepted Answer · 2014-05-23 20:04:53Z

2

 worstEnglish = english[i];

Swap the assignment. Right now you are not updating the worstEnglish variable.

public void worstEnglish() {
System.out.println("The Worst English Mark Is");
//Array
int worstEnglish = english[0];
//Method
for (int i=0; i<english.length; i++){
if(english[i] < worstEnglish){
  worstEnglish = english[i];
}//End Of If
}//End of loop

answered May 23, 2014 at 20:04

TGH

39.4k13 gold badges106 silver badges140 bronze badges

Comments

Community · Accepted Answer · 2017-05-23 12:20:54Z

0

Have you tried simplifying this with Collections.min() and Collections.max() instead of doing iterations over the Arrays?

Since you've typed the worstEnglish array as Int, I'm assuming these are Integer values in the array.

I'd image it'd be just worstEnglish = Collection.min(english);

See this SO for example: Finding the max/min value in an array of primitives using Java

edited May 23, 2017 at 12:20

CommunityBot

11 silver badge

answered May 23, 2014 at 20:14

ubergoober

1195 bronze badges

Collectives™ on Stack Overflow

Finding Minimum Number Of An Array?

3 Answers 3

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related