ArrayList giving null pointer exception

Question

I'm parsing an XML file and assigning values of XML to the class variable. Here is the main activity and variable class also:

package com.example.questions;

public class Test extends Activity 
{
  private TextView question;
  private RadioButton rdooption1;
  private RadioButton rdooption2;
  private RadioButton rdooption3;
  private RadioButton rdooption4;
  private static final String FILENAME = "xmlFileName.xml";
  private FileInputStream fin;


  @Override
  protected void onCreate(Bundle savedInstanceState)
  {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.question_layout);   
  }

  @SuppressWarnings("null")
  private void parseXML(XmlPullParser xpp) throws XmlPullParserException, IOException 
  {
    List<QuestionArrayList> questions = null;
    QuestionArrayList currentquestion = null;

    while(xpp.next()!=XmlPullParser.END_DOCUMENT )
    {

      questions= new ArrayList<QuestionArrayList>();

      if (xpp.getEventType() != XmlPullParser.START_TAG) 
      {
        continue;
      }

      String name = xpp.getName();

      if(name.equals("Question"))
      {
        //String questionmy = xpp.nextText();

        //here error is giving                                      
        currentquestion.question_name=xpp.nextText();
      }


      questions.add(currentquestion);
      System.out.println("Size of al after additions: " + questions.size());

      System.out.println("Contents of al: " + questions);

    }
  }      
}

Here is the variable class:

public class QuestionArrayList 
{
    public int question_set_id;
    public int question_id;
    public String question_type;
    public String question_name;
    public String option_one;
    public String option_two;
    public String option_three;
    public String option_four;
}

currentquestion is null doesn't it?

idog
– idog

2014-05-29 13:22:23 +00:00
Commented May 29, 2014 at 13:22 — idog
– idog, Commented May 29, 2014 at 13:22
yes currentquestion is null

Pravin Bhosale
– Pravin Bhosale

2014-05-29 13:27:03 +00:00
Commented May 29, 2014 at 13:27 — Pravin Bhosale
– Pravin Bhosale, Commented May 29, 2014 at 13:27
@user3384222 So initialize it. Check my answer.

Piyush
– Piyush

2014-05-29 13:28:51 +00:00
Commented May 29, 2014 at 13:28 — Piyush
– Piyush, Commented May 29, 2014 at 13:28

Piyush · Accepted Answer · 2014-05-29 13:22:19Z

3

Initialize your QuestionArrayList class. You have just declared variable for it.

currentquestion = new QuestionArrayList():

answered May 29, 2014 at 13:22

Piyush

18.9k5 gold badges35 silver badges64 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Bhavesh Jethani · Accepted Answer · 2014-05-29 13:33:00Z

while(xpp.next()!=XmlPullParser.END_DOCUMENT )
    {

      questions= new ArrayList<QuestionArrayList>();
currentquestion = new QuestionArrayList():

//initialize cuurrentqeustion here.

      if (xpp.getEventType() != XmlPullParser.START_TAG) 
      {
        continue;
      }

      String name = xpp.getName();

      if(name.equals("Question"))
      {
        //String questionmy = xpp.nextText();

        //here error is giving                                      
        currentquestion.question_name=xpp.nextText();


      questions.add(currentquestion);
      }

//as per your condition it will add blank currentquestion in question array list..
//its bettter put it question.add(currentquestion) inside if condition.


      //questions.add(currentquestion);
      System.out.println("Size of al after additions: " + questions.size());

      System.out.println("Contents of al: " + questions);

    }
  }

Collectives™ on Stack Overflow

ArrayList giving null pointer exception

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related