Javascript global string replace with different elements from array?

Question

I'm a Javascript noob using regex in javascript to globally replace text on web page. Easy enough.

v = v.replace(/\Simon\b/g, "JS Noob");

I know I can replace with functions, but I can't get this to work:

v = v.replace(/\bSimon\b/g, function(replaceLoop) {
    var myStringArray = ["herp","derp","clueless","hurrrrr"];
    var arrayLength = myStringArray.length;
    for (var i = 0; i < arrayLength; i++){
        replaceLoop = myStringArray;
        return replaceLoop;
    } 
}

I have a feeling I'm thinking about this all wrong.

What exactly are you trying to do? Also provide your input and expected output? — anubhava
– anubhava, Commented Jun 4, 2014 at 15:28

Paul S. · Accepted Answer · 2014-06-04 15:30:43Z

2

Step 1, make a function which returns the next item from an Array each time

function iterGen(arr, i) {
    i || (i = 0);
    return function () {
        i %= arr.length;
        return arr[i++];
    };
}

Step 2, pass this into your replace

v = v.replace(/\bSimon\b/g, iterGen(["herp","derp","clueless","hurrrrr"]));

answered Jun 4, 2014 at 15:30

Paul S.

66.6k9 gold badges129 silver badges143 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Sam Over a year ago

Interesting, I took it as OP wanting a random index instead of iterating through with each replacement.

plalx Over a year ago

Starting form JS 1.7 you can simply do var arr = [1, 2, 3], it = arr.iterator(), next = it.next.bind(it);

Paul S. Over a year ago

@plalx I really like some things in 1.7, and many are re-designed and included in ES 6, but you can't rely on browser support for 1.7 - it's basically gecko only

simontarr Over a year ago

I was unclear in my question... I was actually looking for a random index that, not really stepping through, since that would reach the end of the array. However, this is helpful and answers another question that I know I'll run into. Thank you.

Sam · Accepted Answer · 2014-06-04 15:29:22Z

0

A quick syntax error is causing issues, you are missing the closing ); to .replace(). Also, you are setting replaceLoop = myStringArray instead of a specific string. Assuming you want a random index, you'll need Math.random().

v = v.replace(/\bSimon\b/g, function(replaceLoop) {
    var myStringArray = ["herp","derp","clueless","hurrrrr"];
    var arrayLength = myStringArray.length;
    var index = Math.floor(Math.random() * arrayLength);

    return myStringArray[index];
});

answered Jun 4, 2014 at 15:29

Sam

20.5k2 gold badges48 silver badges71 bronze badges

1 Comment

simontarr Over a year ago

That's exactly it! I had a syntax error AND a conceptual mistake. Your answer solves both... thank you!

Collectives™ on Stack Overflow

Javascript global string replace with different elements from array?

2 Answers 2

4 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related