Replace n patterns in a string

Question

Is there an easy way to fix this code:

title_1 = $(this).closest('tr').find('td').html();
title_2 = $(this).closest('tr').find('td').next().html();
title_3 = $(this).closest('tr').find('td').next().next().html();

question = question.replace(/{title_1}/g, title_1);
question = question.replace(/{title_2}/g, title_2);
question = question.replace(/{title_3}/g, title_3);

So it isn't so dully (repeated) and can cover n occurences of title_ pattern?

I'm a beginner Javascript developer and a complete regular expressions newbie (actually, they scare me! :|), so I'm unable to do this by myself. I've tried to look for an inspiration in different languages, but failed.

Guffa · Accepted Answer · 2014-06-06 09:10:25Z

2

You can use a function in the replace, to get the value depending on what you find:

question = question.replace(/{title_(\d+)}/g, $.proxy(function(x, m){
  return $(this).closest('tr').find('td:eq('+(m-1)+')').html();
}, this));

Demo: http://jsfiddle.net/n3qrL/

edited Jun 6, 2014 at 9:10

answered Jun 6, 2014 at 8:57

Guffa

703k111 gold badges760 silver badges1k bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

xdazz Over a year ago

m should be the second parameter.

Guffa Over a year ago

@xdazz: Yes, you are correct. Thanks for spotting that.

xdazz · Accepted Answer · 2014-06-06 08:55:01Z

2

String.prototype.replace() could take a function as second parameter.

var $this = $(this);
question = question.replace(/\{title_(\d+)\}/g, function(match, n) {
  return $this.closest('tr').find('td').eq(n - 1).html();
});

answered Jun 6, 2014 at 8:55

xdazz

161k38 gold badges255 silver badges278 bronze badges

Comments

Silz · Accepted Answer · 2014-06-06 09:10:21Z

1

Demo Here

Try this , Generalized for getting all td tag's text value :

$("table").find("tr").each(function(){

 $(this).find("td").each(function(){
     alert($(this).html());
     var txt=$(this).html();
     //var pattern="/{"+txt+"}/g";
     //question = question.replace(pattern, txt);
 });
});

NB. In your question you have not mentioned the value for 'question' . please define value for 'question'

edited Jun 6, 2014 at 9:10

answered Jun 6, 2014 at 9:05

Silz

2561 silver badge5 bronze badges

1 Comment

trejder Over a year ago

Yeap, you're right! I was always told to paste only imporant parts of code, when asking questions in SE.

RobG · Accepted Answer · 2014-06-06 09:30:19Z

1

It seems to me that you want to get the text content of the first three cells of a table row and use it to replace the content of a string, and that this is an element somewhere in the row. So you can do:

var n = 3;  // number of cells to get the text of
var textArray = [];
var tr = $(this).closest('tr')[0];
var reString;

for (var i=0; i<n; i++) {
  reString = '{title_' + (i+1) + '}';
  question = question.replace(reString, tr.cells[i].textContent);
}

If you wish to avoid jQuery's closest, you can use a simple function like:

function upTo(el, tagName) {
  tagName = tagName.toLowerCase();
  do {
    el = el.parentNode;
    if (el.tagName && el.tagName.toLowerCase() == tagName) {
      return el;
    }
  } while (el.parentNode)
}

then:

var tr = upTo(this, 'tr');

edited Jun 6, 2014 at 9:30

answered Jun 6, 2014 at 9:08

RobG

148k32 gold badges180 silver badges216 bronze badges

1 Comment

trejder Over a year ago

Yeap, you're right! The only difference (as exposed in last question's paragraph) is, that I want this for n cells of a table row, no for just the three first.

Collectives™ on Stack Overflow

Replace n patterns in a string

4 Answers 4

2 Comments

Comments

1 Comment

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

Comments

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related