Undefined is not a function error when using factory method in angularJS

Question

I'm having problems finding the solution to TypeError: undefined is not a function in my code. I have the following app.js:

var app =  angular.module('test', ['ngRoute', 'test.services', 'test.directives', 'test.controllers']);
app.config(function ($routeProvider, $httpProvider, $locationProvider) {

  $locationProvider.html5Mode(true);

  $routeProvider.
    when('/q/:q', {
      templateUrl: '/templates/productlist.html',
      controller: 'ProductCtrl'
    }).
    otherwise({
      redirectTo: '/q'
    });

});

Then I have a controller

var controllers = angular.module('test.controllers', []);
controllers.controller('ProductCtrl', ['$scope', '$routeParams', 'ProductFactory',
  function ($scope, ProductFactory, $routeParams) {

    $scope.query = $routeParams.q;
    $scope.products = ProductFactory.query({query: $scope.query});
  }]);

And a factory

var services = angular.module('test.services', ['ngResource']);
var baseUrl = 'http://localhost\\:8080';
services.factory('ProductFactory', function ($resource) {
    return $resource(baseUrl + '/test/smart/:query', {}, {
        query: { method: 'GET', isArray: true }
    })
});

This code results on load in the above mentioned TypeError on the line $scope.products = ProductFactory.query({query: $scope.query}); in my controller. Further, when debugging my code I see that $routeParams.q is null or undefined. What I want is that in my controller the $scope.products variable becomes an array with the result of the query.

What am I doing wrong?

msapkal · Accepted Answer · 2015-04-16 05:01:34Z

10

Please try with correct function arguments,

controllers.controller('ProductCtrl', ['$scope', '$routeParams', 'ProductFactory',
  function ($scope /*ProductFactory*/, $routeParams, ProductFactory) {

    $scope.query = $routeParams.q;
    $scope.products = ProductFactory.query({query: $scope.query});
  }]);

edited Apr 16, 2015 at 5:01

answered Jun 9, 2014 at 16:41

msapkal

8,3462 gold badges34 silver badges48 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

PieterDB Over a year ago

Yes, it works, thanks a lot! However, I don't understand why the order of the arguments is important?

gkalpak Over a year ago

@PieterDB: That's the whole point of inlne array notation in DI (arguments' name is irrelevant, only the position is). Take a look at the docs.

Collectives™ on Stack Overflow

Undefined is not a function error when using factory method in angularJS

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related