remove text without slicing in Python

Question

Currently learning python modules and functions and the task is to simply display a list without any built in functions (other than range() and str(), can't use slice expressions, list methods or string methods either.

So using this that we're not supposed to edit:

list1 = ['q', 'w', 'e', 'r', 't', 'y']
emptyList = []

string = my_string(list1)
print(string)
print(my_string(emptyList))

and this that I made myself:

def my_string(first_list)

    my_string = "List: "

    for x in range(len(first_list)):

        my_string += str(first_list[x]) + ", "

    return my_string[:-2]

currently outputs:

List: q, w, e, r, t, y
List

The correct output should be:

List: q, w, e, r, t, y
List:

The slice that i'm not supposed to use cuts off the final comma on the first list, however also takes of the colon on the second. How would I go about removing the final comma and keeping the colon without using a slice expression?

I'd normally ask my prac tutor but I don't have another lesson for another week

The pythonic way would be to use join - I guess that's not allowed either to make it artificially complex? — dornhege
– dornhege, Commented Jun 10, 2014 at 12:45

nicolas.leblanc · Accepted Answer · 2014-06-10 12:50:08Z

1

You could try this (inspired by dornhege's answer):

def my_string(first_list)

    my_string = "List: "

    for x in range(len(first_list)):

        if x == 0:

            my_string += str(first_list[x])

        else

            my_string += ", " + str(first_list[x])

    return my_string

answered Jun 10, 2014 at 12:50

nicolas.leblanc

6508 silver badges27 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

dornhege · Accepted Answer · 2014-06-10 12:44:33Z

1

The straight-forward way is: Don't put the comma in in the first place.

Basically put a comma before each entry unless it's the first.

I'll leave the coding for you to learn.

answered Jun 10, 2014 at 12:44

dornhege

1,5008 silver badges8 bronze badges

Comments

Veedrac · Accepted Answer · 2014-06-10 12:48:19Z

1

The canonical way to deal with edge-cases is to specialize:

def my_string(first_list)
    my_string = "List: "

    for x in range(len(first_list)):
        my_string += str(first_list[x]) + ", "

    # Can only crop string if it has a trailing ", "
    if first_list:
        my_string = my_string[:-2]

    return my_string

There are of course better ways of dealing with this precise problem (eg. for item in first_list), but that's for later learning.

Note that += on strings (or any immutable sequence, like tuples) in a loop is bad and this is only remotely acceptable because this is a learning excercise.

answered Jun 10, 2014 at 12:48

Veedrac

60.7k15 gold badges120 silver badges177 bronze badges

5 Comments

llrs Over a year ago

Could you explain why is bad to do += in a loop? Thanks

Veedrac Over a year ago

Basically on bad days it can have O(n²) performance [read the second link first]. This is because each time you add strings it needs to rebuild everything. It's like building a house, but every time you add a brick you have to rebuild the whole house. Obviously that's a bad idea.

llrs Over a year ago

Oh, so the += is O(n²). Thanks I hadn't read yet this questions and the answers are quite educative!

Veedrac Over a year ago

It's not quite that simple. I couldn't find a clear answer so I'll write one now.

Veedrac Over a year ago

stackoverflow.com/questions/24145155/…

s16h · Accepted Answer · 2014-06-10 12:48:38Z

You don't need to use a slice. Using mostly your own code, the following will work by putting a comma after every element unless it's the last element:

def my_string(first_list):

    my_string = "List: "

    for x in range(len(first_list)):

        my_string += str(first_list[x]) 
        if x != len(first_list) - 1:
            my_string += ", "

    return my_string

list1 = ['q', 'w', 'e', 'r', 't', 'y']
emptyList = []
string = my_string(list1)
print(string)
print(my_string(emptyList))

Having said that, I understand that this is an exercise but it's definitely not the best way to do this. Just for reference, a more Pythonic way to do this would be:

list1 = ['q', 'w', 'e', 'r', 't', 'y']
emptyList = []
print('List: {}'.format(', '.join(list1)))
print('List: {}'.format(', '.join(emptyList)))

user2923089 · Accepted Answer · 2014-06-10 12:50:08Z

1

Just "if" statement in the beginning and you won't need a lot of repeatable "if"'s

def my_string(first_list)
    my_string = "List: "
    if len(first_list) == 0:
        return my_string
    for x in xrange(len(first_list)):
        my_string += str(first_list[x]) + ", "
    return my_string[:-2]

answered Jun 10, 2014 at 12:50

user2923089

394 bronze badges

Comments

ch3ka · Accepted Answer · 2014-06-10 13:07:36Z

1

The pythonic way would be to use str.join like so:

def my_string(lst):
    return "List: " + ", ".join(lst)

But since you are not allowed to use string methods, you have to emulate join by yourself.

Since join is pretty useful and generic, you might want to create a reusable function for it:

def my_join(items, sep):
     tmpstr = ''
     for item in items:
         if tmpstr:
             tmpstr += sep
         tmpstr += item
     return tmpstr

and use it via:

def my_string(lst):
    return "List: " + my_join(lst,", ")

If you are not even allowed to create helper functions on your own, then you have to combine the code of my_string and my_join into my_string, of course.

answered Jun 10, 2014 at 13:07

ch3ka

12.2k5 gold badges33 silver badges28 bronze badges

Collectives™ on Stack Overflow

remove text without slicing in Python

6 Answers 6

Comments

Comments

5 Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

Comments

Comments

5 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related