Java coding style - calling a method inside a class

Question

I want to call a validation method inside a shared gwt class that i have created to store the validation logic (for user entered text fields)

 suggestBox.addKeyUpHandler( new KeyUpHandler() {
            public void onKeyUp(KeyUpEvent event) {
                if (event.getNativeKeyCode() == KeyCodes.KEY_ENTER) { 
                    String boxText = suggestBox.getText();
                    if (new FieldVerifier().validUserName(boxText)) { //inner class used to instanciate the FieldVerifier class where validUserName(String ..) lives

now i could do this with a properly instanciated FieldVerifier class (rather than a inner class as above) - or indeed, perhaps make it abstract. but i have the suspicion i am missing something (ie. must be an elegant way of doing it).

looked on google code search, but didnt come across anything particularly helpful..

Is suggestBox.addKeyUpHandler( new KeyUpHandler() { in a method that is part of FieldVerifier ? — Bozho
– Bozho, Commented Mar 10, 2010 at 22:44

Bozho · Accepted Answer · 2010-03-10 22:02:49Z

1

I'm not sure I got it, but try:

FieldVerifier.this.validUserName(boxText);

answered Mar 10, 2010 at 22:02

Bozho

599k147 gold badges1.1k silver badges1.2k bronze badges

Sign up to request clarification or add additional context in comments.

Comments

jackbot · Accepted Answer · 2010-03-10 22:15:29Z

0

If you made the validUserName() method of FieldVerifier static then you could just call FieldVerifier.validUerName() directly, without having to instantiate a FieldVerifier object. If it's a fairly small class, though, the overhead of creating a new object is likely to be minimal.

answered Mar 10, 2010 at 22:15

jackbot

3,0313 gold badges29 silver badges35 bronze badges

2 Comments

malangi Over a year ago

I did start with making it static - but eclipse seemed to suggest i should only 'call it in a static context' so i wasnt sure if this was a wonky practice. it seems though (from the comments above) that instantiating objects for uses such as this seems to be OK in java?

jackbot Over a year ago

If the FieldVerifier class isn't consuming a bunch of resources in its constructor (say if it's just initialising a few variables or something) then you're not going to notice anything by instantiating a new object just to call validUserName() so it's fine to do that.

mR_fr0g · Accepted Answer · 2010-03-10 22:13:54Z

0

i could do this with a properly instanciated FieldVerifier class (rather than a inner class as above)

Your use of FieldVerifier is not an inner class. It is indeed 'properly instanciated'. KeyUpHandler is an example of an anonymous inned class.

answered Mar 10, 2010 at 22:13

mR_fr0g

8,7527 gold badges42 silver badges55 bronze badges

Comments

MattGrommes · Accepted Answer · 2010-03-10 22:21:10Z

0

If I understand what you're trying to do, I would make validUserName() a static method. It doesn't appear to require or change any state; you just pass in something, run some verification logic on it, then return a boolean. This case is when you want to start looking at using statics.

answered Mar 10, 2010 at 22:21

MattGrommes

12.4k10 gold badges39 silver badges40 bronze badges

Collectives™ on Stack Overflow

Java coding style - calling a method inside a class

4 Answers 4

Comments

2 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related