Angular JS Dependency Injection - Best Practice

Question

I recently started working on my first Angular JS project, and I want to make sure I'm handling Multiple dependance injection correctly. Any suggestions or feed back will be greatly appreciated!

var app = angular.module('app', [
  'ngRoute',
  'ngIdle',
  'ui.bootstrap'
]);

app.controller('testCtrl', [
  '$scope', '$http', '$timeout', '$location', 'SessionService',
  function($scope, $http, $timeout, $location, SessionService) {

  // Do Stuff
}]);

This way IMO is the most human-readable, and you need to define the initial array with the dependencies names, because if you want to minify your code angular still need to old references to the dependencies. — Emanuel Ralha
– Emanuel Ralha, Commented Jun 16, 2014 at 15:50

calebboyd · Accepted Answer · 2014-06-16 16:08:05Z

2

I imagine you're just wondering about syntax here, There are a few different ways:

MyAppModule.controller("MyCtrl",MyCtrl);
MyCtrl.$inject = ['$scope', '$http', '$timeout', '$location', 'SessionService'];
function MyCtrl($scope, $http, $timeout, $location, SessionService){
    //..do stuff
}

I like this way because it is pretty decoupled, and can be separated easily from angular, wrapped up in a !function(){}() will keep it out of the global space. This way is also the least work for the injector initialization.

Then there is the array syntax you have shown. That's nice if you like brackets (}])).

You can also forgo manually writing the string names and use a build tool like ngmin. Though you'd have to follow the guidelines for declaring your dependencies.

I wouldn't say there are any certain best practices associated with any of this, but its more of a preference.

answered Jun 16, 2014 at 16:08

calebboyd

5,7332 gold badges25 silver badges32 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

jassok Over a year ago

Awesome thanks. You were correct in assuming I'm just looking at syntax. I hate ugly code and poor syntax, so I just wanted to make sure I'm doing it correctly.

Collectives™ on Stack Overflow

Angular JS Dependency Injection - Best Practice

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related