Javascript inner loop stops outer loop on first occurence

Question

I have nested two for loops like below. But the inner loop stops the outer loop in the first occurence. On execution,the below code gives only my 13th row in grey color where the expected behaviour is to see the 13th,14th and 15th row in grey color.

 var rows = document.getElementsByTagName("tr");
 for(var i = 0, max = rows.length;i < max;  i++)
 {

     var cells = rows[i].getElementsByTagName("td");
     if (rows[i].cells[4].innerHTML == "Asset Removed")
      {
        for(var inner = 0, max = rows[inner].cells.length;inner < max;  inner++)
         {
         cells[inner].style.backgroundColor = "grey";
         }

      }
 }

Any ideas?

@Kernel.. That worked.I dint notice that variable actually.Thank You. — Dency G B
– Dency G B, Commented Jun 18, 2014 at 7:17

Niels Keurentjes · Accepted Answer · 2014-06-18 07:18:29Z

2

for(var i = 0, max = rows.length;i < max;  i++)
    for(var inner = 0, max = rows[inner].cells.length;inner < max;  inner++)

The max variable in the inner loop is the same as in the outer loop, hence overwriting its values, thus causing the i < max end condition to become unreliable.

answered Jun 18, 2014 at 7:18

Niels Keurentjes

42.1k9 gold badges103 silver badges138 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

chandu · Accepted Answer · 2014-06-18 07:20:43Z

2

You are using same variable in inner and outer loops. in javascript last assigned value is taken by variable as final value so change the inner loop max variable to some another name. try this one.

var rows = document.getElementsByTagName("tr");
 for(var i = 0, max = rows.length;i < max;  i++)
 {

     var cells = rows[i].getElementsByTagName("td");
     if (rows[i].cells[4].innerHTML == "Asset Removed")
      {
        for(var inner = 0, max1 = rows[inner].cells.length;inner < max1;  inner++)
         {
         cells[inner].style.backgroundColor = "grey";
         }

      }
 }

I have changes the inner loop max variable to max1

answered Jun 18, 2014 at 7:20

chandu

2,2763 gold badges23 silver badges35 bronze badges

Collectives™ on Stack Overflow

Javascript inner loop stops outer loop on first occurence

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related