Program stops after assigning values to struct using scanf

Question

In the following code, the program stops without any errors when I assign it's members values using scanf.

#include <stdio.h>

typedef struct {
        int hours, minutes, seconds;
} Time;

int main (void) {
    Time getTime (void);
    Time time;

    time = getTime();

    printf ("%i:%i:%i", time.hours, time.minutes, time.seconds);
}

Time getTime (void) {
    Time time;

    printf ("Enter time (hh:mm:ss): ");
    scanf ("%i:%i:%i", time.hours, time.minutes, time.seconds);

    return time;
}

A sample of the output: Enter time (hh:mm:ss): 12:12:12 - then the program stops executing

When I add \n to the last printf to flush the buffer, it still doesn't change anything. I've tried to initialize both structures with default values but it made no difference i.e. Time time = {0, 0, 0};

David Ranieri · Accepted Answer · 2014-06-20 08:46:01Z

3

scanf's arguments are of pointer type. Place & before with each parameter of scanf

scanf ("%i:%i:%i", &time.hours, &time.minutes, &time.seconds);

edited Jun 20, 2014 at 8:46

David Ranieri

41.2k8 gold badges58 silver badges103 bronze badges

answered Jun 20, 2014 at 8:38

haccks

107k28 gold badges181 silver badges274 bronze badges

Sign up to request clarification or add additional context in comments.

8 Comments

David Ranieri Over a year ago

prototype is defined in main

haccks Over a year ago

@AlterMann; Missed that :)

user2849447 Over a year ago

@AlterMann It is perfectly valid to locally declare a function prototype in other function.

haccks Over a year ago

@user2849447; He is not saying it is wrong. He just informed me about that.

user2849447 Over a year ago

@AlterMann Will do! :)

|

Collectives™ on Stack Overflow

Program stops after assigning values to struct using scanf

1 Answer 1

8 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

8 Comments

Your Answer

Sign up or log in

Post as a guest

Related