Html.ValidationMessage is empty despite message added to ModelState

Question

I am trying to use the ModelState.AddErrrorModel and Html.ValidationMessage("Account") together, to show an error message.

However, even though I can debug the model error is being added on my POST, I cannot see it on the view when the view is loaded again.

Code run on POST from the form, where I can see the ModelState.AddModelError is being called (ex.Message do have a value as well):

            try {
               // code that fails in this case
            }
            catch (Exception ex)
            {
                logger.Error(ex);
                ModelState.AddModelError("Register",ex.Message);
            }

            return RedirectToAction("Account", accountViewModel);

My view looks like this:

 <h3>Get your free account now</h3>
        @using (Html.BeginForm("Register", "Home", FormMethod.Post, new { @class = "form" }))
        {
            // trying to test different methods to get my errors... NOTHING works :)
            @Html.ValidationSummary()
            @Html.ValidationMessage("Register")
            @Html.BusinessErrorMessageBox()


            <div class="form-group">
                <label>Email address</label>
                @Html.TextBoxFor(m => m.RegisterViewModel.Email, new { @class = "form-control", placeholder = "Email", @type = "email" })
                @Html.ValidationMessageFor(m => m.RegisterViewModel.Email)
            </div>
            <div class="form-group">
                <label>Password</label>
                @Html.PasswordFor(m => m.RegisterViewModel.Password, new { @class = "form-control", placeholder = "Password" })
                @Html.ValidationMessageFor(m => m.RegisterViewModel.Password)
            </div>
            <div class="form-group">
                <label>Your country (the country where you live or where your organization is registered in)</label>
                @Html.DropDownListFor(model => model.RegisterViewModel.SelectedCountry, Model.RegisterViewModel.Countries, new { @class = "form-control" })
            </div>
            <input type="submit" class="btn btn-primary btn-lg" value="Get your free account now" />
        }

For practical reasons, my view is called Account, and the method accepting the POST, is called "Register".

But no matter what I do, there is no errors being shown in either the ValidationMessage or ValidationSummary.

Any idea what I am doing wrong?

EDIT:

FYI: there are two forms in the view, if that might have an influrence.

EDIT 2:

I can see the following HTML is being outputted when clicking the button that goes to my server. The value ex.Message, shows nowhere:

<div class="validation-summary-valid" data-valmsg-summary="true"><ul><li style="display:none"></li>
</ul></div><span class="field-validation-valid" data-valmsg-for="Business" data-valmsg-replace="true"></span><span class="field-validation-valid" data-valmsg-for="Register" data-valmsg-replace="true"></span>

Have you tried ModelState.AddModelError(string.Empty ,ex.Message); with @Html.ValidationSummary(true) — user3559349
– user3559349, Commented Jun 21, 2014 at 11:30
Just tried. That did not help, unfortunately. FYI - there is also 2 forms on the page — Lars Holdgaard
– Lars Holdgaard, Commented Jun 21, 2014 at 11:31

Daniel J.G. · Accepted Answer · 2014-06-23 13:04:04Z

1

+50

The result from your POST action is always a redirect:

return RedirectToAction("Account", accountViewModel);

That means your error messages will be lost, since the redirect will tell the browser to send another GET request for the Account action, where you will render a fresh Register view with no errors.

The flow that you want is:

POST logic succeeds, return a redirect to Account, which in turn will send a GET request
POST logic fails, return the same view so errors can be displayed

Your POST method would look something like this:

try {
    //your logic here

    //Everything worked, return a redirect
    return RedirectToAction("Account", accountViewModel);
}
catch (Exception ex)
{
    logger.Error(ex);
    ModelState.AddModelError("Register",ex.Message);
}

//If we get here, something went wrong. Return the view so errors are displayed
return View("Account", accountViewModel);

Hope it helps!

answered Jun 23, 2014 at 13:04

Daniel J.G.

35.2k9 gold badges117 silver badges115 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Praval 'Shaun' Tirubeni Over a year ago

This should be correct. Returning the model to the view and not redirecting should work

Lars Holdgaard Over a year ago

Fantastic. Thanks a lot for that answer, that solves my problem. I will award bounty when i can (19 hrs!)

Praval 'Shaun' Tirubeni · Accepted Answer · 2014-06-21 20:47:46Z

0

Actually, what you want is:

@Html.ValidationSummary(false)

You want all errors shown on the form: reference. Since you are not attaching the model error to a specific property, the error is not shown on any form element validation.

answered Jun 21, 2014 at 20:47

Praval 'Shaun' Tirubeni

6704 silver badges10 bronze badges

3 Comments

Lars Holdgaard Over a year ago

Unfortunately, that did not change anything in the view :-( thanks for trying though

Praval 'Shaun' Tirubeni Over a year ago

That is extremely weird. If you do a view source on the page and look just below the form, is there any errors displayed then?

Lars Holdgaard Over a year ago

You can see the HTML output now :-)

Collectives™ on Stack Overflow

Html.ValidationMessage is empty despite message added to ModelState

2 Answers 2

2 Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related