Why is the last array in my loop the only array to display in my view?

Question

I have an array of arrays, and when I loop through the array the only one displayed is the last array.

Here is the code that loops through the arrays;

@events.each do |event|
  def get_sig_class_id(sig_id)
    IpsSignature.where('sig_id =?', sig_id).first.sig_class_id
  end
  sig_id = get_sig_class_id(event.signature)
  event_class_data.push(sig_id)
  @event_class_array = Array.new(event_class_data.group_by {|x| x}.map {|k,v| [k,v.count]})
  @event_class_array.each do |x|
    @event_class = x
  end
end

If I display @event_class_array in my view I get this [[1, 54], [30, 1], [2, 1]]

If I display @event_class in the view I only get [2, 1]

I'm looking to get [1, 54], [30, 1], [2, 1] with @event_class (single arrays, not an array of arrays as in @event_class_array, and not just the last one).

My displaying in the view is simply to see what data I'm getting returned, this will eventually end up in a Highcharts pie chart.

Here are my views, nothing much to see here..

<%= @event_class_array %>

and

<%= @event_class %>

That's hard to read. Why do you define a method in your loop? Also, you're setting event_class instead of appending to it. — Dave Newton
– Dave Newton, Commented Jun 22, 2014 at 22:52
You're setting the value to x instead of appending to an array. Also, canonical Ruby would use map/collect instead of appending inside an each loop. — Dave Newton
– Dave Newton, Commented Jun 22, 2014 at 22:58
And I don't see the point of defining that method inside a loop. — Dave Newton
– Dave Newton, Commented Jun 22, 2014 at 22:59
Thanks for clearing this up, I'll move the methods. I'm new to development and I was getting undefined method errors, so thats how I got it working. — insecure-IT
– insecure-IT, Commented Jun 22, 2014 at 23:10

Jorge de los Santos · Accepted Answer · 2014-06-22 22:56:09Z

2

  @event_class_array.each do |x|
    @event_class = x
  end

this code means that for each array, @event_class is rewrited with the x. So only the last one is stored there.

If you want to insert all arrays you should do

  @event_class = [] 
  @event_class_array.each do |x|
    @event_class << x
  end

answered Jun 22, 2014 at 22:56

Jorge de los Santos

4,6431 gold badge22 silver badges38 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

opticon · Accepted Answer · 2014-06-22 22:55:10Z

0

@event_class_array.each do |x|
    @event_class = x
end

You're overwriting @event_class every time that line fires. Change it to something like

@event_class_array.each do |x|
    @event_class += x
end

And you should be good.

answered Jun 22, 2014 at 22:55

opticon

3,5945 gold badges41 silver badges68 bronze badges

Collectives™ on Stack Overflow

Why is the last array in my loop the only array to display in my view?

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related