Problems With My Function in Javascript

Question

I'm having problems with some javascript code that I can't seem to figure out. The function I use is

var tagline = new function(){
    document.write(
        tags[
            Math.floor(Math.random()*10)
        ]
    );
};

which calls on an array of 10 strings called "tags" and displays a random entry from that array.

The problem is that for some reason the function executes even when it isn't called, and when I do call it nothing happens. The function just puts the text in the top left corner and does nothing different whether it is or isn't called. This is especially a problem with the styling, because no matter what I do I can't change the position, size, etc. of the text.

(Yes, I'm aware I can do the same thing with

document.getElementById("tag").innerHTML = tags[Math.floor(Math.random()*10)] ;

but I like to write my own functions.)

Thank you for any help you can give!

It is because of the new keyword, it shouldn't be there

edi9999
– edi9999

2014-06-25 18:39:21 +00:00
Commented Jun 25, 2014 at 18:39 — edi9999
– edi9999, Commented Jun 25, 2014 at 18:39

MrCode · Accepted Answer · 2014-06-25 18:39:56Z

9

It's because you use the new keyword. Remove that so it becomes:

var tagline = function(){

By using the new keyword, you are instantiating a new object from the function, which immediately calls it, and your variable then contains the object, not the function, which explains why you can't call it after it first executes.

answered Jun 25, 2014 at 18:39

MrCode

64.6k10 gold badges95 silver badges114 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Newspire Over a year ago

Thank you! That fixed the problem I was having, but now when I call the function nothing happens. My HTML looks something like <head> <script src="//ajax.googleapis.com/ajax/libs/jquery/1.10.2/jquery.min.js"></script> <script type="text/javascript" src="templateScript.js"></script> </head> <body> <p id="tag" onload="tagline();"></p> </body>

MrCode Over a year ago

Don't use onload on a p tag. Use window.onload instead.

Collectives™ on Stack Overflow

Problems With My Function in Javascript

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related