Uncaught TypeError: Cannot set property 'value' of null, JavaScript

Question

I keep on getting this error when using this code. SRC --> http://jsfiddle.net/MYG2C/1/

JS

    <input class="menu1" type="submit" value="Total : 0.00" onclick="m.getTotal()" id="total" />

HTML

var m = {
    total:0,
    getTotal: function () {
        this.total = this.total.toFixed(2);
        document.getElementByID("total").value = "Total : " + this.total;
    },
}
m.total = 5;
//Clicking the button should now update the text on the button.

Anthony Chu · Accepted Answer · 2014-06-26 07:34:23Z

2

Two problems...

getElementByID should be getElementById
this.total = this.total.toFixed(2); will work the first time because total is a number. After that it becomes a string and toFixed is not a valid method on a string

Updated Fiddle

answered Jun 26, 2014 at 7:34

Anthony Chu

37.6k10 gold badges85 silver badges72 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Krish · Accepted Answer · 2014-06-26 10:02:19Z

1

you have a typo as anthony chu mentioned and below is the modified script for check the type and avoid the Uncaught TypeError.

var m = {
    total:8,
    getTotal: function () {
        if(typeof this.total == "number")
        {
        console.log("executed");
        this.total = this.total.toFixed(2);
        document.getElementById("total").value = "Total : " + this.total;
        }
    },
}

JSFIDDLE : http://jsfiddle.net/8J2G7/4/

answered Jun 26, 2014 at 10:02

Krish

2,68010 gold badges45 silver badges63 bronze badges

Collectives™ on Stack Overflow

Uncaught TypeError: Cannot set property 'value' of null, JavaScript

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related