Adding variable instead of concatenating with jquery each

Question

I'm using jQuery's .each() and grabbing some numbers. I'm doing some math with those numbers and I'm trying to add the result, but instead of adding it's concatenating. Here's my code so far:

if (zName == 'Premium') {
    $('.product-total .productitemcell .productitemcell').each(function (index, value) {
        oPrice = parseFloat($(this).text().replace('$', ''));
        nPrice = parseFloat(oPrice - (oPrice * (10 / 100))).toFixed(2);
        subTotal += nPrice;
        $(this).html('<s>$' + oPrice + '</s> <span style="color:#ef0f0f;">$' + nPrice + '</span>');
    });
}
console.log(subTotal);

Pointy · Accepted Answer · 2014-06-30 20:25:25Z

3

The .toFixed() function returns a string, not a number.

(Also, "oPrice", "nPrice", and "subTotal" should be declared with var; perhaps they are in code not shown.)

Converting from the return value of .toFixed() won't necessarily preserve any fraction truncation that's taken place. Doing monetary math with JavaScript floating-point math is tricky and error-prone.

edited Jun 30, 2014 at 20:25

answered Jun 30, 2014 at 20:17

Pointy

415k62 gold badges600 silver badges631 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Damien Over a year ago

They are declared elsewhere. So i tried doing subtotal+=parseFloat(nPrice); but now i'm getting a Nan error.

Pointy Over a year ago

@Damien make sure that you initialize "subTotal" to zero somewhere.

Damien Over a year ago

Awesome! What's funny is that at one point i did initialize it to zero but that didn't work so i moved on. Thanks again!

Collectives™ on Stack Overflow

Adding variable instead of concatenating with jquery each

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related