AngularJS forEach issue

Question

I already have this foreach that sets the selected value for the state in statesList correctly for a _searchParam[key] that == the state.id.
However, if the _searchParam[key] contains more than one value in this format" "NH,TX" then the if statement fails and the match never occurs so all items get selected set to false.

var _states = [];
angular.forEach($scope.statesList, function (state, key2) {
    if(_searchParams[key].indexOf(state.id) > -1)
        if(state.id == _searchParams[key]) {
        state.selected = true;
    } else {
        state.selected = false;        
    }
    this.push(state);
    if(state.selected)
        $scope.states.push(state);
}, _states);

So, I tried to split the _searchParams[key] value and loop through them but it is not working. See error in comment

var _states = [];
angular.forEach($scope.statesList, function (state, key2) {
    if(_searchParams[key].indexOf(state.id) > -1)
        var sp = _searchParams[key].split(',');
        for(i = 0; i < sp.length; i++) {
            if(state.id == sp[i]) {
                state.selected = true;
            } else {
               state.selected = false;        
            }
        }
    }
    this.push(state); // get unexpected token this
    if(state.selected)
        $scope.states.push(state);
}, _states);

So, I moved the this.push(state) line into the if (where it really should be anyway), and get the error below.

var _states = [];
angular.forEach($scope.statesList, function (state, key2) {
    if(_searchParams[key].indexOf(state.id) > -1)
        var sp = _searchParams[key].split(',');
        for(i = 0; i < sp.length; i++) {
            if(state.id == sp[i]) {
                state.selected = true;
            } else {
               state.selected = false;        
            }
        }
        this.push(state); 
    }
    if(state.selected)  // get unexpected token if
        $scope.states.push(state);
}, _states);

Now how can I fix this as I'm not sure what is going on in this forEach() that would be causing these errors? The statesList is defined like this:

$scope.statesList = [
    { "id": "AK", "name": "Alaska", "selected": false},
    { "id": "AL", "name": "Alabama", "selected": false},
    // SNIPPED most of states
    { "id": "WY", "name": "Wyoming", "selected": false},
    { "id": "DC", "name": "District of Columbia", "selected": false},
    { "id": "MX", "name": "Mexico", "selected": false}];

user3141592 · Accepted Answer · 2014-07-01 19:08:48Z

1

It appears that you are missing an opening curley brace {. Add it, like this:

if(_searchParams[key].indexOf(state.id) > -1) {

And then take out the split part you added. Otherwise, in some cases you'd set state.selected to true then to false.

edited Jul 1, 2014 at 19:08

answered Jul 1, 2014 at 19:03

user3141592

1,1302 gold badges10 silver badges23 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

MB34 Over a year ago

That did the job, it's amazing how overlooking those things can get you into trouble and how sometimes you just can't see the littlest thing. Thanks. I actually modified it a little bit to correctly handled the setting of the selected value, too.

Collectives™ on Stack Overflow

AngularJS forEach issue

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related