std::unique_ptr and pointer to pointer

Question

I want to use std::unique_ptr in combination with FreeImage's FITAG. The code in plain C would be:

... load image;

FITAG* tag = NULL;
FreeImage_GetMetadata(FIMD_EXIF_EXIF, bitmap, "Property", &tag);
... do some stuff with tag;
FreeImage_DeleteTag(tag);

... delete image;

My attempt with unique_ptr:

std::unique_ptr<FITAG, void(*)(FITAG*)> tag(NULL, &FreeImage_DeleteTag);
FreeImage_GetMetadata(FIMD_EXIF_EXIF, bitmap, "Property", &tag.get());

which obviously returns:

cannot take the address of an rvalue of type 'pointer' (aka 'FITAG *')

How would I solve this?

Thanks a lot in advance.

If FreeImage_DeleteTag doesn't have a signature which unique_ptr will accept, then write a wrapper function which does have a necessary signature and which then calls FreeImage_DeleteTag appropriately. — TheUndeadFish
– TheUndeadFish, Commented Jul 3, 2014 at 0:26

Praetorian · Accepted Answer · 2014-07-03 00:27:03Z

11

Reverse the order of operations; first acquire the resource and then construct the unique_ptr.

FITAG *p = NULL;
FreeImage_GetMetadata(FIMD_EXIF_EXIF, bitmap, "Property", &p);
std::unique_ptr<FITAG, void(*)(FITAG*)> tag(p, &FreeImage_DeleteTag);

answered Jul 3, 2014 at 0:27

Praetorian

110k20 gold badges248 silver badges340 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

user2848971 · Accepted Answer · 2014-07-03 00:24:51Z

3

tag.get()

This returns an r-value. You can't get the address of an r-value( temporary ). Your best bet is to do this instead:

auto ptr = tag.get();
FreeImage_GetMetadata(FIMD_EXIF_EXIF, bitmap, "Property", &ptr);

This will allow you to pass a FITAG** into the function. If you meant to pass a FITAG* into the function, just remove the & since tag.get() returns the pointer, not the value.

FreeImage_GetMetadata(FIMD_EXIF_EXIF, bitmap, "Property", tag.get());

answered Jul 3, 2014 at 0:24

user2848971

1 Comment

Praetorian Over a year ago

Your first example will compile, but the unique_ptr will no longer own the resource allocated by FreeImage_GetMetadata.

Collectives™ on Stack Overflow

std::unique_ptr and pointer to pointer

2 Answers 2

Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related