Common functions and helpers ASP.NET MVC

Question

I don't get something, and if somebody can clarify:

I need to access this function / helper from here and there:

namespace Laf.Helpers
{
    public class Common
    {
        public string TimeSpanToString(TimeSpan val)
        {
            return val.ToString(@"hh\:mm");
        }
    }
}

And in my controller I access it by:

var tmp = new Common();
string str = tmp.TimeSpanToString(tp.DepartureTime);
transferPoint.Add(
    new ListTransferPointVM { PortName = tp.PortName, DepartureTime = str }
str);

And the question is how can I achieve and not have duplicate in every controller:

DepartureTime = TimeSpanToString(tp.DepartureTime)

Possible Answer I just found a way that compiler is not frowning on:

public class TransferController : Controller
{
    private Common common = new Common();

    public ActionResult Index ()
    {
      ...

and later, when I need it:

string time = common.TimeSpanToString((TimeSpan)variable);

Simon · Accepted Answer · 2014-07-05 20:02:08Z

4

You could make your method string TimeSpanToString(TimeSpan) a static method. This way you can access it without having to make a Common object. Your code will look as follows:

namespace Laf.Helpers
{
    public class Common
    {
        public static string TimeSpanToString(TimeSpan val)
        {
            return val.ToString(@"hh\:mm");
        }
    }
}

And your Controller:

transferPoint.Add(
    new ListTransferPointVM { 
        PortName = tp.PortName, 
        DepartureTime = Common.TimeSpanToString(tp.DepartureTime) }
    Common.TimeSpanToString(tp.DepartureTime));

EDIT: As suggested by Michael Petrotta an extension method would be better. An implementation could be:

namespace LaF.ExtensionMethods
{
    public static class MyExtensions
    {
        public static string TimeSpanToString(this TimeSpan ts)
        {
            return ts.ToString(@"hh\:mm");
        }
    }
}

You can now call the method like:

tp.DepartureTime.TimeSpanToString();

3 Comments

Michael Petrotta Over a year ago

An extension method would be even better.

Simon Over a year ago

To the TimeSpan class? I agree. I had not thought about that solution yet, thanks!

HerGiz Over a year ago

And I agree with MichaelPetrotta. That didn't came to mind to. And to @Simon: I was searching for months to achieve this and no luck. I have started to do more complex app and I need this, and... Didn't see tree from the forest :( Thanks a bunch

Collectives™ on Stack Overflow

Common functions and helpers ASP.NET MVC

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related