Python does not accept some numeric inputs

Question

With this code, all I am trying to do is insert a dash between odd numbers and an asterisk between even ones. It does not work correctly with every input. It works with, e.g. 46879, but returns None with 468799, or does not insert * between 4 and 6 with 4546793. Why is it doing that? Thanks

def DashInsertII(num): 

 num_str = str(num)

 flag_even=False
 flag_odd=False

 new_str = ''
 for i in num_str:
  n = int(i)
  if n % 2 == 0:
   flag_even = True
  else:
   flag_even = False
  if n % 2 != 0:
   flag_odd = True
  else:
   flag_odd = False
  new_str = new_str + i
  ind = num_str.index(i)

  if ind < len(num_str) - 1:
   m = int(num_str[ind+1])
   if flag_even:
    if m % 2 == 0:
      new_str = new_str + '*'
   else:                 
    if m % 2 != 0:
      new_str = new_str + '-'                     
 else:
  return new_str  
 print DashInsertII(raw_input())

Use 4 spaces or a tab to indent your code. This is barely readable. Also you did not add a return at the end of the function. — JBernardo
– JBernardo, Commented Jul 7, 2014 at 20:20
num_str.index(i) will always return the first occurrence. You can't expect ind+1 to point to the next number if index returned the first occurrence, instead of the succeeding occurrence. — alvits
– alvits, Commented Jul 7, 2014 at 20:23
@alvits he could get the index by just using enumerate(num_str) in the loop signature. — Rafael Barros
– Rafael Barros, Commented Jul 7, 2014 at 20:28
@RafaelBarros - Although your suggestion will solve his problem, it doesn't give him insight where he went wrong. I think the fastest way to learning is to understand where they went wrong. You should post your suggestion as one of the alternative answers and I'll upvote it too. — alvits
– alvits, Commented Jul 7, 2014 at 20:50

Community · Accepted Answer · 2017-05-23 11:59:35Z

5

Your function definition is one of the most overbuilt functions I've seen in a while; the following should do what yours was trying to do, sans the complexity.

def DashInsertII(num):
  num_str = str(num)

  new_str = ''
  for i in num_str:
    n = int(i)
    if n % 2 == 0:
      new_str += i + '*'
    else:
      new_str += i + '-'
  return new_str
print DashInsertII(raw_input())

EDIT: I just re-read the question and saw that I misinterpreted what you want, which is to insert a - between two odd numbers and a * between two even numbers. For that, the best solution I can come up with uses regular expressions.

Second Edit: As per alvits's request, I'm including an explanation of the regex in this.

import re

def DashInsertII(num):
  num_str = str(num)

  # r'([02468])([02468])' performs capturing matches on two even numbers
  #    that are next to each other
  # r'\1*\2' is a string consisting of the first match ([02468]) followed
  #    by an asterisk ('*') and the second match ([02468])
  # example input: 48 [A representation of what happens inside re.sub()]
  #    r'([02468])([02468])' <- 48 = r'( \1 : 4 )( \2 : 8 )'
  #    r'\1*\2' <- {\1 : 4, \2 : 8} = r'4*8'
  num_str = re.sub(r'([02468])([02468])',r'\1*\2',num_str)
  # This statement is much like the previous, but it matches on odd pairs
  #    of numbers
  num_str = re.sub(r'([13579])([13579])',r'\1-\2',num_str)

  return num_str

print DashInsertII(raw_input())

If this is still not what you actually want, please comment on this to let me know.

edited May 23, 2017 at 11:59

CommunityBot

11 silver badge

answered Jul 7, 2014 at 20:27

RevanProdigalKnight

1,3261 gold badge14 silver badges23 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

alvits Over a year ago

+1 You could add some explanation to your regular expressions for the benefit of the OP and others who might stumble into this thread.

RevanProdigalKnight Over a year ago

@alvits Good suggestion, I've edited the post to include that.

Maddy · Accepted Answer · 2016-04-29 04:54:48Z

RevanProdigalKnight's answer is almost right but fails when 3 or more even/odd numbers come together.

The right way to do this with regex would be to use positive lookahead (use ?=).

def insert_right_way(num):
    #your code here
    num_str = str(num)
    num_str = re.sub(r'([13579])(?=[13579])', r'\1-', num_str)
    num_str = re.sub(r'([02468])(?=[02468])', r'\1*', num_str)
    return num_str

def DashInsertII(num):
    num_str = str(num)
    num_str = re.sub(r'([02468])([02468])',r'\1*\2',num_str)
    num_str = re.sub(r'([13579])([13579])',r'\1-\2',num_str)

    return num_str


print insert_right_way(234467776667888)

print DashInsertII(234467776667888)

This would output:

234*4*67-7-76*6*678*8*8 ( what is desired)
234*467-776*6678*88   ( not what we wanted)

furas · Accepted Answer · 2014-07-07 20:39:28Z

0

If I understand your problem - for 11223344 you need 1-12*23-34*4

def DashInsertII(num): 

    prev_even = ( int(num[0])%2 == 0 )

    result = num[0]

    for i in num[1:]:

        curr_even = (int(i)%2 == 0)

        if prev_even and curr_even:
            result += '*'                
        elif not prev_even and not curr_even:
            result += '-'

        result += i

        prev_even = curr_even

    return result

print DashInsertII(raw_input())

answered Jul 7, 2014 at 20:39

furas

149k12 gold badges121 silver badges171 bronze badges

2 Comments

postoronnim Over a year ago

After casting number to string, it worked beautifully. Very neat, thanks!

furas Over a year ago

raw_input() gives always string so I removed str() from version in question.

Collectives™ on Stack Overflow

Python does not accept some numeric inputs

3 Answers 3

2 Comments

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related