Recursion with nested array with hashes

Question

I'm not getting this to work correctly.

I have an array of hashes with a nested arrays of hashes of varying depth. If any of the nested results are false it must return false otherwise true.

array = [
  {
    result: true,
    dependents: [
      {
        result: true,
        dependents: [
          {result: true},
          {result: false}
        ]
      }
    ]
  },
  result: true,
  dependents: []
]

def result(array)
   if array.find {|line| line[:result] == false}
    return false
   else
    array.each do |line| 
      result(line[:dependents])
    end
  end
  true    
end

result(array)
#=> true (should be false)

The method result() is not working correctly at the moment as it is returning true for the given array and should be false. Any ideas?

It helps people answering you if you break-down complex data into something that fits into the default code display width. The more readable your question is, the easier it is for others to understand, and the faster they can help you. — the Tin Man
– the Tin Man, Commented Jul 14, 2014 at 18:10

fbonetti · Accepted Answer · 2014-07-14 16:44:45Z

1

You're recursively calling the result method but you aren't breaking when the result of that call returns false.

def result(array)
  array.each do |h|
    return false if h[:result] == false
    return false if h[:dependents] && result(h[:dependents]) == false
  end

  true
end

answered Jul 14, 2014 at 16:44

fbonetti

6,6724 gold badges36 silver badges32 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Cary Swoveland Over a year ago

You might consider showing your code returns the correct values for one array where it should return true and another for where it should return false. I prefer key? to checking if a hash value is nil, as nil values are permitted.

andreofthecape Over a year ago

Thanks, works and I found I could extend your solution easier.

konsolebox · Accepted Answer · 2014-07-14 16:33:16Z

1

  result(line[:dependents])

Probably must be

  return false if not result(line[:dependents])  ## Or unless ...

Or perhaps simply

  result(line[:dependents]) or return false

answered Jul 14, 2014 at 16:33

konsolebox

76.3k13 gold badges110 silver badges114 bronze badges

1 Comment

andreofthecape Over a year ago

Thanks, this works, just found @fbonetti answer easier to extend.

Collectives™ on Stack Overflow

Recursion with nested array with hashes

2 Answers 2

2 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related