c - implementing insertion algorithm

Question

i have implemented insertion algorithm in c programming language, but i have faced a little problem when tried to extend it to both increasing and decreasing order, the problem is about that a little piece of code is repeat :

typedef int order_t;

#define INCREASING  0
#define DEACREASING 1

extern void insertion_sort(int *const arr, size_t arr_size, order_t order) {
    register size_t i, j;
    register int key;

    for(i = 1; i < arr_size; ++i) {
        key = arr[i];

        if(order == INCREASING) 
            for(j = i - 1; j >= 0 && arr[j] > key; --j) {
                arr[j+1] = arr[j];
            }
        else {
            for(j = i - 1; j >= 0 && arr[j] < key; --j) {
                arr[j+1] = arr[j];
            }
        }

        arr[j+1] = key;
    }
}

there is a ways to do so the for statement and a[j+1] = arr[j] inside the for will be written only one time?

SoleZero · Accepted Answer · 2014-07-17 00:40:10Z

3

for(i = 1; i < arr_size; ++i) {
    key = arr[i];

    for(j = i - 1; j >= 0 && (order == INCREASING ? (arr[j] > key) : (arr[j] < key)) ; --j) {
         arr[j+1] = arr[j];
    }

    arr[j+1] = key;
}

answered Jul 17, 2014 at 0:40

SoleZero

462 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

user2698605 · Accepted Answer · 2014-07-17 00:49:02Z

0

And what about a little change in your constants?

typedef int order_t;

#define INCREASING  (+1)
#define DEACREASING (-1)

extern void insertion_sort(int *const arr, size_t arr_size, order_t order) {
    register size_t i, j;
    register int key;

    for(i = 1; i < arr_size; ++i) {
        key = arr[i];

        for(j = i - 1; j >= 0 && ((arr[j] - key) * order < 0); --j) {
            arr[j+1] = arr[j];
        }

        arr[j+1] = key;
    } 
 }

answered Jul 17, 2014 at 0:49

user2698605

Collectives™ on Stack Overflow

c - implementing insertion algorithm

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related