PHP Function parameters - problem with var not being set

Question

So I am obviously not a very good programmer. I have written this small function:

function dispAdjuggler($atts) {
extract(shortcode_atts(array(
    'slot' => ''
), $atts)); 

$adspot = '';
$adtype = '';

// Get blog # we're on
global $blog_id;
switch ($blog_id) {
    case 1:
        // root blog HOME page
        if (is_home()) {
            switch ($slot) {
                case 'top_leaderboard':
                    $adspot = '855525';
                    $adtype = '608934';
                break;
                case 'right_halfpage':
                    $adspot = '855216';
                    $adtype = '855220';
                break;
                case 'right_med-rectangle':
                    $adspot = '858222';
                    $adtype = '613526';
                break;
                default:
                    throw new Exception("Ad slot is not defined");
                break;
            }

When I reference the function on a page like so:

<?php dispAdjuggler("top_leaderboard"); ?>

The switch is throwing the default exception. What am I doing wrong here?

Thanks!!

Marc B · Accepted Answer · 2010-03-22 20:37:32Z

2

Without know what the shortcode_atts() function does, it looks like you're passing in array to set default values ('slot' = empty string), which extract() then converts into $short = ''

extract(shortcode_atts(array(
    'slot' => ''
), $atts));

right? Now that $slot is the empty string, it won't match any of the cases in your switch, and therefore the default case gets triggered, which throws the "Ad slot is not defined" exception.

answered Mar 22, 2010 at 20:37

Marc B

362k44 gold badges433 silver badges508 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

cnemelka · Accepted Answer · 2010-03-22 20:37:33Z

0

Aren't you missing the extract type parameter?

http://us.php.net/manual/en/function.extract.php

answered Mar 22, 2010 at 20:37

cnemelka

35 bronze badges

1 Comment

cnemelka Over a year ago

try: extract(shortcode_atts(array( 'slot' => '' ),EXTR_OVERWRITE , $atts)); or just add an additional ","

Collectives™ on Stack Overflow

PHP Function parameters - problem with var not being set

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related