Access html elements created by js in other js functions

Question

I am trying to access html elements that I create in one js function in another function. I have this code

EDIT after comments: here is a jsfiddle http://jsfiddle.net/8uTxM/

</button>" +"<button value='1' type='button' class='as' id='c2' onclick='cA(this);'>"

in this function

function cA (element){
var x = element.value;

if (x === allQuestions[questionNumber].correctAnswer) {
    element.setAttribute.style.backgroundColor = "green";
    ++score;
    }
}

I am trying to make the button green when it is clicked. However, I get the error: Cannot set property 'backgroundColor' of undefined

I assume this has something to do with timing, but I cannot figure out why. Especially since the element.value bit works (the++score works fine, every right question adds +1 to the score variable)

General remark: A HTML element's ID must not start with a number. (see stackoverflow.com/questions/70579/…). Most browsers will probably tolerate it, but it's better to avoid going against the rules. — UweB
– UweB, Commented Jul 28, 2014 at 9:22
First off, its getElementById not getElementsById. Second, if you use on click you should define your function as a function (onclick="functionName();"). Third, you could try passing the this to your function and eliminating the need for separate functions altogether: onclick="setIndId(this);", and then passing it your function function setIndId(element){ element.setAttribute("id",0+questionNumber)}. But it's very complicated to figure out like this, so please provide a fiddle or a reference to your code somewhere (if it is readable and not over complex) — somethinghere
– somethinghere, Commented Jul 28, 2014 at 9:22

Anup Singh · Accepted Answer · 2014-07-28 09:24:32Z

1

One problem that I may guess is you are using "getElementsById"

either go for "getElementById" or "getElementsByTagName"

answered Jul 28, 2014 at 9:24

Anup Singh

1,5733 gold badges16 silver badges32 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

user3807702 · Accepted Answer · 2014-07-28 09:20:48Z

0

Why don't you create a <div> in your html/php page which would be empty with the answers class, and then change its id/innerHTML ?

answered Jul 28, 2014 at 9:20

user3807702

557 bronze badges

1 Comment

Valentin Zambelli Over a year ago

I create the div dynamically to hide it more easily. each div gets assigned the question number. When the next button is clicked, the current question is assigned a .hidden class.

Collectives™ on Stack Overflow

Access html elements created by js in other js functions

2 Answers 2

Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related