AngularJS Noob: How to call functions in controller from "init"?

Question

I'm trying to keep things DRY so I moved my repetitive code into a function in my controller, but it's now saying that the function is undefined: Error: setFilterChoices is not defined

app.controller('MensCtrl', ['$scope', "MensEyeglass", "MensSunglass", "Color", "Shape", "Material", function($scope, MensEyeglass, MensSunglass, Color, Shape, Material) {

  $scope.init = function(category) {
    $scope.colors = [];
    $scope.shapes = [];
    $scope.materials = [];

    switch (category) {
    case "Eyeglasses":
      $scope.products = MensEyeglass.query({}, setFilterChoices(data));
      break;
    case "Sunglasses":
      $scope.products = MensSunglass.query({}, setFilterChoices(data));
      break;
    }
  }


  //it's defined here isn't it??
  $scope.setFilterChoices = function(data) {
    for (var i = 0; i < data.length; i++) {
      var product = data[i];

      if ($scope.shapes.indexOf(product.shape) == -1) {
        $scope.shapes.push(product.shape);
      }

      if ($scope.materials.indexOf(product.material) == -1) {
        $scope.materials.push(product.material);
      }


      for (var j = 0; j < product.products_colors.length; j++) {
        var product_color =  product.products_colors[j];
        if ($scope.colors.indexOf(product_color.color) == -1) {
          $scope.colors.push(product_color.color);
        }
      }
    }
  }

I was missing the function(data) callback as well. Here's the answer:

  $scope.products = MensSunglass.query({}, function(data) {
    $scope.setFilterChoices(data);
  });

Ben Wilde · Accepted Answer · 2014-07-29 20:49:34Z

3

its on the scope so use $scope.setFilterChoices(data) when u call it.

answered Jul 29, 2014 at 20:49

Ben Wilde

5,7023 gold badges43 silver badges36 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

bigpotato Over a year ago

Nice. Thanks! How would I do it without using the scope?

Ben Wilde Over a year ago

var setFilterChoices = function(data) { ... }, or function setFilterChoices(data) { ... }. then call it as you originally did

Collectives™ on Stack Overflow

AngularJS Noob: How to call functions in controller from "init"?

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related