PHP INSERT Not working, possible bad array?

Question

Hey guys im getting really stuck and could use some help,

I have a query that runs like this

$query = sprintf("SELECT TN,point,source FROM table LIMIT ".$_POST['cases']."");
$result = mysql_query($query);

Then in the while loop i am able to echo

echo "&nbsp;&nbsp;&nbsp;&nbsp;".$row['0']." and ".$row['1']." and ".$row['2']."<br>";

And get the proper result for each $row['']

My problem is when adding these into the insert statement.

mysql_query("INSERT INTO assigned (TN,point,date1,dude,test,row,rows) VALUES (".$row['0'].",".$row['1'].",'$date','$df','$dx','$num',".$row['2'].")");

The only thing holding the queryback is the $row['2'], if i remove and make it '123' it will properly insert row 0 and 1 and the rest of the data. Ive tried almost all combination to get this to work and im having no luck.

Not strong with PHP, but I sure hope sprintf() sanitizes input — Sterling Archer
– Sterling Archer, Commented Jul 30, 2014 at 19:16
I'll just come out and say it's probably due to an sql injection attack vulnerability, plus a serious case of cargo-cult programming. Combined with a total lack of any kind of error handling, perfect recipe for this kind of question. — Marc B
– Marc B, Commented Jul 30, 2014 at 19:16
@SterlingArcher: it does nothing. it's a useless call too, since there's no % placeholders in the target string. — Marc B
– Marc B, Commented Jul 30, 2014 at 19:16
@SterlingArcher: it's a direct equivalent of C's sprintf. Most of PHP is just a wrapper around equivalent underlying libc calls. — Marc B
– Marc B, Commented Jul 30, 2014 at 19:17

Alexander Tarasov · Accepted Answer · 2014-07-30 19:16:38Z

2

Try to add single quotation marks around $row['2'], like this:

mysql_query("INSERT INTO assigned (TN,point,date1,dude,test,row,rows) VALUES (".$row['0'].",".$row['1'].",'$date','$df','$dx','$num','".$row['2']."')");

answered Jul 30, 2014 at 19:16

Alexander Tarasov

4885 silver badges8 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

StathisG Over a year ago

mysql_* is deprecated as of PHP 5.5. Use mysqli or PDO instead.

StathisG Over a year ago

@raidenace Using a deprecated function is usually a bad practice, no matter the question asked. I believe that answers should mention these issues (at least when it's possible to do so), even if they seem irrelevant.

renfley Over a year ago

Alex Thanks a million!!! havnt got a clue why that works but it does.. and StathisG, Its an update for app on an old server. Thanks Guys For all the help.

Collectives™ on Stack Overflow

PHP INSERT Not working, possible bad array?

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related