ASP.NET MVC TempData used for wrong request

Question

I use TempData to keep ModelState during redirects (using MvcContrib technique). This works fine. However, in rare cases, user aborts request and then immediate fires another (e.g. quickly clicks on another menu item). This causes ModelState errors to appear on that page, for which it does not belong.

The problem is that TempData is stored in Session. This means, ANY request can grab it, e.g. the one that comes first to the server.

Are there any known workarounds? E.g. keep "destination page" in the TempData along with saved ModelState.

Darin Dimitrov · Accepted Answer · 2010-03-25 13:01:53Z

2

In my opinion TempData should only be used in actions that redirect immediately. For example:

public ActionResult Index()
{
    TempData["foo"] = "bar";
    return RedirectToAction("About");
}

public ActionResult About() 
{
    var foo = TempData["foo"];
    return View();
}

You should avoid storing something into the TempData and render a view:

public ActionResult Index()
{
    TempData["foo"] = "bar";
    // bad :-(
    return View("About");
}

Use Session to achieve what you are looking for or add some unique ID that allow you to identify the correct request.

Another common technique you could use instead of TempData is to serialize the model on the client (a sort of a ViewState if you will).

edited Mar 25, 2010 at 13:01

answered Mar 25, 2010 at 12:55

Darin Dimitrov

1.0m276 gold badges3.3k silver badges3k bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

queen3 Over a year ago

My question is exactly about "actions that redirect immediately". Issue would not happen if I just render view after assigning tempdata. And TempDate DO use Session so this advice makes no sense. The very problem is that there's no such thing as "immediate redirect" - another request caused by user click can abort it and come next. As for serializing ModelState in the view, I thought about it, but thanks for the link.

queen3 Over a year ago

No, I can't serialize in view. The flow is "get POST - check errors - set ModelState - redirect to page that shows messages". There's no "view" between "check errors" and "page that shows messages".

Collectives™ on Stack Overflow

ASP.NET MVC TempData used for wrong request

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related