Error in creating BIN File using Binary File C#

Question

I am creating a Binary File in C# here using the following code below. It is relatively simple code below. The RawData variable is a type string[].

     using (BinaryWriter bin = new BinaryWriter(File.Open("file.bin", FileMode.Create)))
        {
            foreach (string data in RawData)
            {
                int Byte = Convert.ToInt32(data, 16);
                bin.Write(Byte);


            }

        }

Unfortunately the BIN File is produced like this. It places the correct byte value but then skips the next three bytes and places zeros there and then places the next byte value. Does anyone know why this happens. I have used debugged and the bin.Write(Byte), and these extra zeros are NOT sent to this method.

BIN File Capture

Use Convert.ToByte, and a byte type. sizeof(int) == 4. — Lucas Trzesniewski
– Lucas Trzesniewski, Commented Aug 8, 2014 at 15:20
I am having trouble now when adding this code to my Forms Application. When I tested this in my simple Console app it worked beautifully. Now I moved this code into an Event Handler in my Forms application, and it is producing a terrible result of a binary file not even close to the one I need. — tennis779
– tennis779, Commented Aug 8, 2014 at 19:19

Jon Skeet · Accepted Answer · 2014-08-08 15:22:59Z

3

You're using BinaryWriter.Write(int). So yes, it's writing 4 bytes, as documented.

If you only want to write one byte, you should use BinaryWriter.Write(byte) instead.

So you probably just want:

bin.Write(Convert.ToByte(data, 16));

Alternatively, do the whole job in two lines:

byte[] bytes = RawData.Select(x => Convert.ToByte(x, 16)).ToArray();
File.WriteAllBytes("file.bin", bytes);

answered Aug 8, 2014 at 15:22

Jon Skeet

1.5m893 gold badges9.3k silver badges9.3k bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

tennis779 Over a year ago

I am having trouble now when adding this code to my Forms Application. When I tested this in my simple Console app it worked beautifully. Now I moved this code into an Event Handler in my Forms application, and it is producing a terrible result of a binary file not even close to the one I need.

Jon Skeet Over a year ago

Well without any more information about the input, expected output or actual output, it's hard to know what's wrong. I suggest you ask a new question with all the relevant details.

Scott Langham · Accepted Answer · 2014-08-08 15:20:59Z

2

Try

var Byte = Convert.ToByte(....)

instead.

You're converting to int, each of which is 4 bytes. So, you see three of them are all zero, and just one byte of the int is the value you expect.

answered Aug 8, 2014 at 15:20

Scott Langham

60.9k44 gold badges139 silver badges214 bronze badges

Collectives™ on Stack Overflow

Error in creating BIN File using Binary File C#

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related