Data validation within data validation

Question

I first want to validate that the user entered a value and to make sure to exit if 'cancel' was pushed. Then, I want to validate that the String releaseDateString is in the correct format at the same time as converting the String to java.sql.Date.

The first validation is taking place but then the JOptionPane carries on repeating itself and does not even consider the try and catch following it.

Here is my method

boolean retry = false;
java.sql.Date releaseDate = null;
String releaseDateString = "";
String title = "";

while (!retry) {
   while(!retry){//field is validated to make sure a value was entered and to exit if cancel was pushed
      releaseDateString = JOptionPane.showInputDialog("Please input the release date of the movie (yyyy-mm-dd)");
      qtd.stringValidation(releaseDateString);  
   }
   try { //the date is validated to make sure it is in the correct format
      releaseDate = java.sql.Date.valueOf(releaseDateString);
   } catch (Exception e) {
      retry = false;
      JOptionPane.showMessageDialog(null, "Make sure you enter a date in the format of 'dd-mm-yyy'");
   }
}

It links to this method

public static boolean stringValidation(String attribute){
   boolean retry = false;
   if (attribute == null){
      System.exit(0);
   }
   else if (attribute.equals("")) //if the cancel button is selected or no value was entered into the 
   {
      JOptionPane.showMessageDialog(null, "Make sure you enter a character into the textbox");
   }
   else {
      retry = true;
   }
   return retry;          
}

This has nothing to do with the problem, but stringValidation is a static method. You should probably not access it through qtd if qtd is an instance. You should access it through your class, like: MyClass.stringValidation. — Edwin Dalorzo
– Edwin Dalorzo, Commented Aug 11, 2014 at 19:22
qtd is actually the name of another class in the same package but thanks anyhow. — Yohi
– Yohi, Commented Aug 11, 2014 at 19:31
Than that's a pretty poor naming convention. Class names in Java follow the Pascal Case naming convention and should start with a upper case letter. Your current pattern will confuse everyone. — Edwin Dalorzo
– Edwin Dalorzo, Commented Aug 11, 2014 at 19:39

Elliott Frisch · Accepted Answer · 2014-08-11 19:20:23Z

2

When you do this,

qtd.stringValidation(releaseDateString);

You aren't assigning the result to retry. I believe you wanted,

retry = qtd.stringValidation(releaseDateString);

answered Aug 11, 2014 at 19:20

Elliott Frisch

202k20 gold badges166 silver badges265 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Hovercraft Full Of Eels Over a year ago

Good answer. 1+ to counter my recent down-vote. Again, sorry.

Collectives™ on Stack Overflow

Data validation within data validation

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related