PHP: Errors in array?

Question

This is my functions.php file and I have gotten an error when I run it. The source code of the file is:

<?php

function data_insert($to, $from, $text, $ip1, $ip2, $ip3, $ua) {
  try {

    $db = pdoConnect();

    $query = 
      "INSERT INTO sms (
        recepient,
        sender,
        message,
        ip1,
        ip2,
        ip3,
        ua,
        result
      )
      VALUES (
        :recepient,
        :sender,
        :message,
        :ip1,
        :ip2,
        :ip3,
        :ua,
        :result
      )";

    $sqlVars = array(
      ':recepient' => $to;
      ':sender' => $from;
      ':message' => $text;
      ':ip1' => $ip1;
      ':ip2' => $ip2;
      ':ip3' => $ip3;
      ':ua' => $ua;
      ':result' => $result;
    );

    $stmt = $db->prepare($query); 

    if (!$stmt->execute($sqlVars)){
      // Error: column does not exist
      return false;
    }

    $inserted_id = $db->lastInsertId();

    $stmt = null;

    return $inserted_id;

  } catch (PDOException $e) {
    addAlert("danger", "Oops, looks like our database encountered an error.");
    error_log("Error in " . $e->getFile() . " on line " . $e->getLine() . ": " . $e->getMessage());
    return false;
  } catch (ErrorException $e) {
    addAlert("danger", "Oops, looks like our server might have goofed. If you're an admin, please check the PHP error logs.");
    return false;
  } 
}
?>

The error is:

Parse error: syntax error, unexpected ';', expecting ')' in /home/appfesti/public_html/functions.php on line 30

Line 30 contains:

$sqlVars = array(

Can anyone help me with the fix? Any help would be appreciated!

you should not terminate the line when you are counting array elements — Ivan Yonkov
– Ivan Yonkov, Commented Aug 12, 2014 at 6:15

Ende Neu · Accepted Answer · 2014-08-12 06:22:48Z

3

Array values must be comma separated:

$sqlVars = array(
  ':recepient' => $to,
   ':sender' => $from,
   ':message' => $text,
   ':ip1' => $ip1,
   ':ip2' => $ip2,
   ':ip3' => $ip3,
   ':ua' => $ua,
   ':result' => $result
 );

edited Aug 12, 2014 at 6:22

answered Aug 12, 2014 at 6:15

Ende Neu

15.8k5 gold badges60 silver badges72 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

EternalHour Over a year ago

It's also the only answer :)

Lorenz Meyer Over a year ago

There should not be a comma on the last line, because this creates an empty element.

Collectives™ on Stack Overflow

PHP: Errors in array?

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related