Codeigniter pass array from Model to Controller

Question

Im trying to send an array of data from the model to the controller but when I echo on controller, I only see the first value no all the array of the values. Whats wrong?

Model:

        $sql = "
        SELECT car_id
        FROM cars
        WHERE price= 1";

        $res = mysql_query($sql);

        $bought_cars= array();
        while ($row_ya = mysql_fetch_object($res)) 
        {
            $bought_cars[] = $row_ya->car_id;
        }
        foreach ($bought_cars as $bought_car) 
        {
                return $bought_car;
        }

Controller

$bought_car = $this->car_model->car();

echo($bought_car);

Thank you in Advance!

you should use CI active record db library and $bought_cars is array so why are not returning whole array? — Girish
– Girish, Commented Aug 12, 2014 at 9:03
foreach ($bought_cars as $bought_car) { return $bought_car; } i think this will return you the last carid am i right — NaveenThally
– NaveenThally, Commented Aug 12, 2014 at 9:04
Possible duplicate of codeigniter passing array data from model to controller — Amaan Iqbal
– Amaan Iqbal, Commented Jul 1, 2017 at 17:30

Harshal · Accepted Answer · 2014-08-12 09:06:57Z

2

You have to use Codeigniter's Active Record Query. In Model (recommended) :

$this->db->select('car_id');
$this->db->from('cars');
$this->db->where('price',1);
$query=$this->db->get();
return $query->result();

Updated Without Active record (Not recommended) :

$sql = "
        SELECT car_id
        FROM cars
        WHERE price= 1";

        $res = mysql_query($sql);

        $bought_cars= array();
        while ($row_ya = mysql_fetch_object($res)) 
        {
            $bought_cars[] = $row_ya->car_id;
        }
        return $bought_cars;//no need to run foreach, you just have to return the array after completing your push operation.

edited Aug 12, 2014 at 9:06

answered Aug 12, 2014 at 9:01

Harshal

3,6329 gold badges40 silver badges67 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

Funereal Over a year ago

It isn't possible to do it without Codeigniter's Active Record Query?

Harshal Over a year ago

But you can do it with Active records ,so no need to use the normal ones.Just change your model function with my code and you will get the array of car_id.

Funereal Over a year ago

But the problem is that when I try to echo on Controller, dont write all the array.

Harshal Over a year ago

if you made changes to return array than you have to use print_r($bought_car) to print the array.

Funereal Over a year ago

With print_r($bought_car) I got the values like this : [0] => 232453 [1] => 212345 [2] How can I do to got them like 232453,212345?

|

Rakesh Sharma · Accepted Answer · 2014-08-12 09:08:58Z

0

you can also use this way like:-

$sql = "SELECT car_id FROM cars WHERE price= 1";
$query = $this->db->query($sql);
return $query->result();

answered Aug 12, 2014 at 9:08

Rakesh Sharma

13.7k5 gold badges41 silver badges44 bronze badges

Comments

Eliel · Accepted Answer · 2014-08-12 09:13:34Z

0

You're using return in your model, which is causing the loop/function to end and only return the first value within your array. Just remove your foreach loop entirely and simply return $bought_cars within your model.

In order to show all the values of your array within your controller you'd have to loop through it.

foreach($bought_car as $car) {
    echo $car . '<br>';
}

Or, if you want to make it more readable you can use:

<pre><?php print_r($bought_car); ?></pre>

answered Aug 12, 2014 at 9:13

Eliel

1646 bronze badges

Comments

Albert Akpama · Accepted Answer · 2014-08-12 09:14:31Z

0

You can use active record to achieve this:

Model

    $this->db-select('car_id')
    $this->db->where('price', 1);               
    $query = $this->db->get('cars'); if($query->num_rows() > 0){
         foreach ($query->result() as $row)
         {
            $data[] = $row;
         }
        return $data;
    }

Controller

    $bought_car = $this->car_model->car(); foreach($bought_car as $car) { echo $car->car_id

}

Remember you SELECTED only car_id so that is the only available column to echo

answered Aug 12, 2014 at 9:14

Albert Akpama

1

Comments

amulamul · Accepted Answer · 2014-08-12 09:18:34Z

0

It ends in first loop returning the first value it gets that's why you get a first value while echoing on controller.Rather do this to return a whole array.

while ($row_ya = mysql_fetch_object($res)) 
    {
        $bought_cars[] = $row_ya->car_id;
    }
return $bought_cars;

edited Aug 12, 2014 at 9:18

answered Aug 12, 2014 at 9:05

amulamul

3903 silver badges14 bronze badges

Collectives™ on Stack Overflow

Codeigniter pass array from Model to Controller

5 Answers 5

6 Comments

Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

6 Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related