Save array data in variable

Question

I use function to solve Huffman coding algorithm but the function take string variable as data but i want it to take array when i write array.ToString() the function out print some unneeded result because i put array no variable. this is function code

public static void GenerateCode(Node parentNode, string code)
{
    if (parentNode != null)
    {
        GenerateCode(parentNode.leftChild, code + "0");

        if (parentNode.leftChild == null && parentNode.rightChild == null)
        Console.WriteLine(parentNode.data + "{" + code + "}");

        GenerateCode(parentNode.rightChild, code + "1");

    }
}

This is my calling for the function in the main:

GenerateCode(parentNode1,array.ToString());

This is photo with the result:

I need don't show System.Int[]

Matthew Haugen · Accepted Answer · 2014-08-12 20:57:19Z

The problem is that array.ToString() isn't overridden by the language. Instead, you probably want to use another function, like string.Concat:

GenerateCode(parentNode1, string.Concat(array));

The result you were getting is because the default implementation of ToString() (object.ToString(), that is) prints out type information.

Although if you do have control over the GenerateCode method, I would strongly suggest modifying its parameter type to accept an IEnumerable<T> or array. Converting to a string, unless necessary, will lose some major benefits of strong-typing. I would make that conversion in the method, not before it. That will allow you to change the implementation later on without worrying about what parameters you pass.

Furthermore, I'd be tempted to write your values to a StringBuilder rather than the console, since that will be way more useful in a majority of real-world applications.

public static void GenerateCode(StringBuilder builder, Node parentNode, IEnumerable<int> values)
{
    if (parentNode != null)
    {
        GenerateCode(builder, parentNode.leftChild, Concat(values, 0));

        if (parentNode.leftChild == null && parentNode.rightChild == null)
            builder.AppendLine(string.Format("{0}{{{1}}}", parentNode.data, string.Concat(values));

        GenerateCode(builder, parentNode.rightChild, Concat(values, 1));
    }
}

private static IEnumerable<T> Concat(IEnumerable<T> coll, T obj)
{
    foreach (var v in coll)
        yield return v;

    yield return obj;
}

Then you can call it, of course, like this.

StringBuilder builder = new StringBuilder();
GenerateCode(builder, parentNode1, array);
Console.Write(builder.ToString());

qJake · Accepted Answer · 2014-08-12 20:42:12Z

1

You want to use string.Join().

GenerateCode(parentNode1, string.Join("", array));

answered Aug 12, 2014 at 20:42

qJake

17.2k17 gold badges88 silver badges138 bronze badges

6 Comments

Jon Over a year ago

Not using commas, its a binary representation I believe

Jon Over a year ago

Now it's just my answer :)

qJake Over a year ago

@Mangist Yes, but linking to MSDN is always recommended when you're referencing a particular method in .NET.

conn Over a year ago

@SpikeX but the result show with the data i put in the array and i don't need that i need only the result of the function

Jon Over a year ago

Sure. I think the example is enough, the asker can Google the .NET method if they want more info. 99% of the time they will just copy/paste your answer into their code.

|

Jon · Accepted Answer · 2014-08-12 20:42:13Z

1

What you need to do is pass in a string representation of your int array.

You can use:

GenerateCode(parentNode1, String.Join("", array));

Which will concatenate all your ints into a string like 10001010101010111011101

answered Aug 12, 2014 at 20:42

Jon

3,2751 gold badge19 silver badges28 bronze badges

Collectives™ on Stack Overflow

Save array data in variable

3 Answers 3

Comments

6 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

6 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related