How to use Container instead of ObjectFactory in StructureMap ServiceActivator?

Question

When implementing DI in WebAPI with StructureMap, we used the ServiceActivator found in

public class ServiceActivator : IHttpControllerActivator
{
    public ServiceActivator(HttpConfiguration configuration) {}    

    public IHttpController Create(HttpRequestMessage request,
           HttpControllerDescriptor controllerDescriptor, Type controllerType)
    {
        var controller = ObjectFactory.GetInstance(controllerType) as IHttpController;
        return controller;
    }
}

But now with the new StructureMap, my ReSharper suggested:

Class 'StructureMap.ObjectFactory' is obsolete: ObjectFactory will be removed in a future 4.0 release of StructureMap. Favor the usage of the Container class for future work

The intellisense on Container gave me only very limited information.

How are we supposed to rewrite our ServiceActivator with the Container class?

Steve Dunn · Accepted Answer · 2016-01-11 18:41:48Z

39

The static stuff is going away. If your not using a Service Locator of some type you're going to have implement your own "ObjectFactory" as referenced here:

public static class ObjectFactory
{
    private static readonly Lazy<Container> _containerBuilder =
            new Lazy<Container>(defaultContainer, LazyThreadSafetyMode.ExecutionAndPublication);

    public static IContainer Container
    {
       get { return _containerBuilder.Value; }
    }

     private static Container defaultContainer()
     {
        return new Container(x =>
        {
               // default config
         });
     }
}

Update: My previous answer was wrong. Thanks @JoeMighty for the heads up.

edited Jan 11, 2016 at 18:41

Steve Dunn

22k11 gold badges66 silver badges91 bronze badges

answered Aug 28, 2014 at 14:13

mxmissile

11.7k6 gold badges57 silver badges85 bronze badges

Sign up to request clarification or add additional context in comments.

14 Comments

Joseph Woodward Over a year ago

Surely this just creates a new instance of an empty container? From my experience that seems to be the case.

mxmissile Over a year ago

@JoeMightly To quote the author "ObjectFactory is just a static facade over Container anyway". However, I will throw up a gist later today that proves this.

Joseph Woodward Over a year ago

I've read this too; however I seem to end up with an empty container. A gist demonstrating this would be greatly appreciated!

mxmissile Over a year ago

@JoeMighty You are correct! I used Service Locator and/or the built in MVC DependencyResolver for resolution with SM3, so I never ran into this problem. However after several tests, as far as I can tell I end up with empty containers like you noted.

Chris Marisic Over a year ago

Service location is not and has not ever been an anti-pattern. Usage of the pattern incorrectly does not make the pattern itself wrong.

|

Collectives™ on Stack Overflow

How to use Container instead of ObjectFactory in StructureMap ServiceActivator?

1 Answer 1

14 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

14 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related