if else statement in JavaScript not working properly

Question

As you can see from this code:

function setBodyClasses() {
    var answer = $surveyAns.getAnswer('QUEST223');
    answer = 'oro';
    if(!surveyUtils.isNullOrWhiteSpace(answer)) {
        if (answer.toLowerCase().indexOf('oro')) {
            $scope.bodyClasses = 'vip_gold';
        }
        else if (answer.toLowerCase().indexOf('platino')) {
            $scope.bodyClasses = 'vip_platinum';
        }
        else {
            $scope.bodyClasses = '';
        }
    }
}

For some reason the if else statement is not working correctly, as you can see the answer value is oro and it should stop on the first if, but when its on the first if condition it compares the value and it moves forward assuming that is not the same value, and for some other reason it enters the second if condition even though the value is different. Any idea why this is happening?

we can't see from screenshot, add the code.

Mritunjay
– Mritunjay

2014-08-28 17:22:18 +00:00
Commented Aug 28, 2014 at 17:22 — Mritunjay
– Mritunjay, Commented Aug 28, 2014 at 17:22
Please post your code as text, not as an image.

gen_Eric
– gen_Eric

2014-08-28 17:23:15 +00:00
Commented Aug 28, 2014 at 17:23 — gen_Eric
– gen_Eric, Commented Aug 28, 2014 at 17:23

gen_Eric · Accepted Answer · 2014-08-28 17:25:25Z

4

You are incorrectly checking if answer contains the string. .indexOf() will return you where in the string it is. It could be 0, that's the start of the string (it's like an array, where it's zero-indexed). It returns -1 if it's not found.

If you just do if(answer.toLowerCase().indexOf('oro')) it will be false, since 0 is "falsly".

You want to do: if(answer.toLowerCase().indexOf('oro') >= 0).

Are you sure you want to use indexOf() in the first place? This is checking if the string "contains" oro. Are you sure you don't just need: if(answer.toLowerCase() === 'oro')?

answered Aug 28, 2014 at 17:25

gen_Eric

228k42 gold badges304 silver badges343 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Laziale Over a year ago

I need to check if the string contains 'oro'. Thank you

juvian · Accepted Answer · 2014-08-28 17:23:47Z

2

indexOf is returning 0, and 0 is a falsy value so its not entering the condition. Should be:

.indexOf('oro') > -1

Same with the other conditions

answered Aug 28, 2014 at 17:23

juvian

16.1k2 gold badges42 silver badges40 bronze badges

Comments

Vardarac · Accepted Answer · 2014-08-28 17:24:14Z

1

You are using indexOf to find the existence of "oro" in your string. IndexOf, however, correctly returns a value of 0, which equates to false in JavaScript. I personally would use answer.indexOf('oro') !== -1.

answered Aug 28, 2014 at 17:24

Vardarac

5632 silver badges17 bronze badges

Collectives™ on Stack Overflow

if else statement in JavaScript not working properly

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related