My function is not running in JavaScript

Question

How do I get this code to work in the "head" tag of the HTML. I must use these two functions, and cannot use only one function. I know this is bad practice, but how would I go about doing this? Thank you for your help.

var myImage;
function prepareEventHandlers() {
    var myImage = document.getElementById('mainImage');
}

function runEvents() {
    myImage.onclick = function() {
        alert('You clicked on the image.');
    };
}

window.onload = function() {
    prepareEventHandlers();
    runEvents();
}

What makes you think "your function is not running"? If you opened your browser's console, you would have found something like TypeError: myImage is undefined. So the function runs, but an error is thrown. — Oriol
– Oriol, Commented Aug 29, 2014 at 2:20
This question is similar to: What is the scope of variables in JavaScript?. If you believe it’s different, please edit the question, make it clear how it’s different and/or how the answers on that question are not helpful for your problem. — dumbass
– dumbass, Commented Oct 9, 2024 at 14:52

levi · Accepted Answer · 2014-08-29 02:06:04Z

3

You need to remove var in prepareEventHandlers(), because you are declaring a new local variable called myImage, not assigning the outer one.

    var myImage;

    function prepareEventHandlers() {
        myImage = document.getElementById('mainImage');
    }

answered Aug 29, 2014 at 2:06

levi

22.8k7 gold badges79 silver badges76 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Steve · Accepted Answer · 2014-08-29 02:07:37Z

3

Remove the "var" in your prepareEventHandlers() function.

var myImage;

function prepareEventHandlers() {
    myImage = document.getElementById('mainImage');
}

function runEvents() {
    myImage.onclick = function() {
        alert('You clicked on the image.');
     };
}  

window.onload = function() {
    prepareEventHandlers();
    runEvents();
}

answered Aug 29, 2014 at 2:07

Steve

864 bronze badges

Collectives™ on Stack Overflow

My function is not running in JavaScript

2 Answers 2

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related