Javascript return function

Question

i want to create some javascript object with few functions, but i get a exception

undefined is not a function

JS:

 var Buses = null;
 $(function () {
        Buses = function() {
            return {
                Test: function () {
                    console.log('test public function');
                }
            }
        }
 });

HTMl:

<button onclick="Buses.Test()">test</button>
<script type="text/javascript" src="js/buses.js" ></script>

What is wrong?

Jindra Helcl · Accepted Answer · 2014-09-07 09:20:53Z

5

Your Buses variable is a function that returns a function so in the HTML it must be called like this

<button onclick="Buses().Test()">test</button>

While you are using jQuery, a better solution would be to give the button an and then assign the click handler right in the javascript:

var Buses = null;
$(function () {
    Buses = function() {
        return {
            Test: function () {
                alert('test public function');
            }
        }
    }

    $("#button").click(function() {Buses().Test()});
});

Here's the fiddle http://jsfiddle.net/fe5hxo60/

edited Sep 7, 2014 at 9:20

answered Sep 7, 2014 at 9:08

Jindra Helcl

3,7661 gold badge24 silver badges27 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Alnitak Over a year ago

he's be better yet creating a single instance of Buses and referring to that in the click handler.

Collectives™ on Stack Overflow

Javascript return function

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related